Bug 1277407 - Add Adjust sandbox keyfile to tree. r=sebastian, a=lizzard
authorMichael Comella <michael.l.comella@gmail.com>
Fri, 03 Jun 2016 16:55:51 -0700
changeset 341641 3e9799b06fe41e72cd7a8d8003e45cf1bf78daa8
parent 341640 1cf4dc5b530279d612e30428a526a1c7a59812d4
child 341642 2ce49ca619922a2f3b5a58788d5f5c64a58eda28
push id1183
push userraliiev@mozilla.com
push dateMon, 05 Sep 2016 20:01:49 +0000
treeherdermozilla-release@3148731bed45 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssebastian, lizzard
bugs1277407, 1277553
milestone49.0a2
Bug 1277407 - Add Adjust sandbox keyfile to tree. r=sebastian, a=lizzard Additionally, we add this file to the tree so it can be used by bug 1277553. The following commit will add the docs explaining how to use the file I added. The added file contents are slurped directly into AdjustConstants.MOZ_INSTALL_TRACKING_ADJUST_SDK_APP_TOKEN. We get the sandbox token from the previously working value in [1]. An alternative solution would be to remove the assertion that `--with-adjust-sdk-keyfile` is specified and provide a default value if the key is not specified. However, after investigating bug 1277553, I dislike this approach because we lose the compile-time checks that a key file is specified, which is dangerous for release/beta builds where the key file may not be valid, we push a release, and we don't get the data we expect. Ideally, we specify `--with-adjust-sdk-keyfile` for non-MOZILLA_OFFICIAL builds, but I don't know how to do that. [1]: https://hg.mozilla.org/mozilla-central/rev/ac75f8f4c01d#l1.26 MozReview-Commit-ID: HPNgiwfzU5p
mobile/android/base/adjust-sdk-sandbox.token
new file mode 100644
--- /dev/null
+++ b/mobile/android/base/adjust-sdk-sandbox.token
@@ -0,0 +1,1 @@
+ABCDEFGHIJKL