Bug 1133175 - Remove SVGTests.hasExtension. r=bz,longsonr
authorCameron McCormack <cam@mcc.id.au>
Thu, 09 May 2019 14:39:28 +1000
changeset 535110 3ce2113ec6925b3eb9f204f7175549f74cac6fc4
parent 535046 34a824c75b7b5618a06ba8987c418d6363da5038
child 535111 1c632bfc14a5f139f9f6e0c5e8194ce02fe9a7cf
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz, longsonr
bugs1133175
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1133175 - Remove SVGTests.hasExtension. r=bz,longsonr
dom/svg/SVGTests.h
dom/webidl/SVGTests.webidl
layout/mathml/tests/test_disabled_chrome.html
layout/svg/tests/test_disabled_chrome.html
testing/web-platform/meta/mathml/relations/html5-tree/required-extensions-1.html.ini
testing/web-platform/meta/svg/historical.html.ini
--- a/dom/svg/SVGTests.h
+++ b/dom/svg/SVGTests.h
@@ -91,16 +91,17 @@ class SVGTests : public nsISupports {
   void GetAttrValue(uint8_t aAttrEnum, nsAttrValue& aValue) const;
 
   void MaybeInvalidate();
 
   // WebIDL
   already_AddRefed<DOMSVGStringList> RequiredFeatures();
   already_AddRefed<DOMSVGStringList> RequiredExtensions();
   already_AddRefed<DOMSVGStringList> SystemLanguage();
+
   bool HasExtension(const nsAString& aExtension) const;
 
   virtual SVGElement* AsSVGElement() = 0;
 
   const SVGElement* AsSVGElement() const {
     return const_cast<SVGTests*>(this)->AsSVGElement();
   }
 
--- a/dom/webidl/SVGTests.webidl
+++ b/dom/webidl/SVGTests.webidl
@@ -11,12 +11,10 @@
  */
 
 [NoInterfaceObject]
 interface SVGTests {
 
   readonly attribute SVGStringList requiredFeatures;
   readonly attribute SVGStringList requiredExtensions;
   readonly attribute SVGStringList systemLanguage;
-
-  boolean hasExtension(DOMString extension);
 };
 
--- a/layout/mathml/tests/test_disabled_chrome.html
+++ b/layout/mathml/tests/test_disabled_chrome.html
@@ -37,18 +37,15 @@ https://bugzilla.mozilla.org/show_bug.cg
     let loadPromise = ContentTaskUtils.waitForEvent(iframeEl, 'load', false);
     t.appendChild(iframeEl);
     await loadPromise;
 
     const contentBR = iframeEl.contentDocument.body.getBoundingClientRect();
 
     ok(chromeBR.height > contentBR.height, "Chrome content height should be bigger than content due to layout");
 
-    ok(!iframeEl.contentDocument.getElementById('svgel').hasExtension("http://www.w3.org/1998/Math/MathML"), 'SVG namespace support is disabled in content iframe');
-    ok(chromeIframeEl.contentDocument.getElementById('svgel').hasExtension("http://www.w3.org/1998/Math/MathML"), 'SVG namespace support is enabled in chrome iframe');
-
     SpecialPowers.setBoolPref("mathml.disabled", initialPrefValue);
   });
 </script>
 </pre>
 </body>
 </html>
 
--- a/layout/svg/tests/test_disabled_chrome.html
+++ b/layout/svg/tests/test_disabled_chrome.html
@@ -33,19 +33,16 @@ https://bugzilla.mozilla.org/show_bug.cg
     iframeEl.src = url;
     let loadPromise = ContentTaskUtils.waitForEvent(iframeEl, 'load', false);
     t.appendChild(iframeEl);
     await loadPromise;
 
     const contentBR = iframeEl.contentDocument.body.getBoundingClientRect();
     ok(chromeBR.height > contentBR.height, "Chrome content height should be bigger than content due to layout");
 
-    ok(!("hasExtension" in iframeEl.contentDocument.getElementById('svgel')), 'SVG is disabled so no hasExtension support is available in content iframe');
-    ok(chromeIframeEl.contentDocument.getElementById('svgel').hasExtension("http://www.w3.org/1998/Math/MathML"), 'SVG namespace support is enabled in chrome iframe');
-
     url = "http://mochi.test:8888/chrome/layout/svg/tests/svg_example_script.svg";
     const iframeElScript = document.createElement("iframe");
     let loadPromiseScript = ContentTaskUtils.waitForEvent(iframeElScript, "load", false);
     iframeElScript.src = url;
     t.appendChild(iframeElScript);
     await loadPromiseScript;
     ok(!iframeElScript.contentDocument.documentElement.style, "Content should not be styled");
 
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/meta/mathml/relations/html5-tree/required-extensions-1.html.ini
@@ -0,0 +1,4 @@
+[required-extensions-1.html]
+  [Testing foreignObject.hasExtension('http://www.w3.org/1998/Math/MathML')]
+    expected: FAIL
+
--- a/testing/web-platform/meta/svg/historical.html.ini
+++ b/testing/web-platform/meta/svg/historical.html.ini
@@ -3,17 +3,14 @@
     expected: FAIL
 
   [SVGZoomAndPan mixin interface must not be exposed]
     expected: FAIL
 
   [SVGGraphicsElement.prototype.getTransformToElement must be removed]
     expected: FAIL
 
-  [SVGGraphicsElement.prototype.hasExtension must be removed]
-    expected: FAIL
-
   [SVGGraphicsElement.prototype.requiredFeatures must be removed]
     expected: FAIL
 
   [SVGSVGElement.prototype.useCurrentView must be removed]
     expected: FAIL