Bug 1521805 - Don't render cached blurs twice. r=gw
☠☠ backed out by 1f6b25d4fa24 ☠ ☠
authorEmilio Cobos Álvarez <emilio@crisal.io>
Tue, 22 Jan 2019 20:00:04 +0000
changeset 514864 3bf9f045d452667c73dca317118fb56202437c41
parent 514863 0a48519a9ad1c62caf6d7fa056ce689070f67d81
child 514865 c229457d7726bd03b056d3e5921c1cc008459fbc
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgw
bugs1521805
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1521805 - Don't render cached blurs twice. r=gw It's pushed to the cached render task list, so we're duplicating work. I missed this in https://github.com/servo/webrender/pull/3444. Thanks for Glenn and Dan for finding it on IRC :) Differential Revision: https://phabricator.services.mozilla.com/D17253
gfx/wr/webrender/src/picture.rs
--- a/gfx/wr/webrender/src/picture.rs
+++ b/gfx/wr/webrender/src/picture.rs
@@ -2750,21 +2750,17 @@ impl PicturePrimitive {
                             let blur_render_task = RenderTask::new_blur(
                                 blur_std_deviation,
                                 picture_task_id,
                                 render_tasks,
                                 RenderTargetKind::Color,
                                 ClearMode::Transparent,
                             );
 
-                            let render_task_id = render_tasks.add(blur_render_task);
-
-                            surfaces[surface_index.0].tasks.push(render_task_id);
-
-                            render_task_id
+                            render_tasks.add(blur_render_task)
                         }
                     );
 
                     PictureSurface::TextureCache(cache_item)
                 }
             }
             PictureCompositeMode::Filter(FilterOp::DropShadow(offset, blur_radius, color)) => {
                 let blur_std_deviation = blur_radius * frame_context.device_pixel_scale.0;