Bug 1431449 - Kill URLSearchParams::ForEach; r=bz
authorAnthony Ramine <n.oxyde@gmail.com>
Thu, 18 Jan 2018 12:20:26 +0100
changeset 454314 3b802a492170509ad5dcf96ba84006294c889f3d
parent 454313 e8f753ce0cfb8d6aae534bab30ee6f4089bf5f55
child 454315 ddb98ad66aa0d86766f4e4bd792d75b432d6f4d9
push id1648
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 12:45:47 +0000
treeherdermozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz
bugs1431449
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1431449 - Kill URLSearchParams::ForEach; r=bz MozReview-Commit-ID: 9woZBRwpb4T
dom/base/BodyUtil.cpp
dom/url/URLSearchParams.h
--- a/dom/base/BodyUtil.cpp
+++ b/dom/base/BodyUtil.cpp
@@ -41,17 +41,17 @@ PushOverLine(nsACString::const_iterator&
     ++aStart; // advance to after CRLF
     return true;
   }
 
   return false;
 }
 
 class MOZ_STACK_CLASS FillFormIterator final
-  : public URLSearchParams::ForEachIterator
+  : public URLParams::ForEachIterator
 {
 public:
   explicit FillFormIterator(FormData* aFormData)
     : mFormData(aFormData)
   {
     MOZ_ASSERT(aFormData);
   }
 
--- a/dom/url/URLSearchParams.h
+++ b/dom/url/URLSearchParams.h
@@ -172,26 +172,16 @@ public:
 
   void Sort(ErrorResult& aRv);
 
   void Stringify(nsString& aRetval) const
   {
     Serialize(aRetval);
   }
 
-  typedef URLParams::ForEachIterator ForEachIterator;
-
-  bool
-  ForEach(ForEachIterator& aIterator) const
-  {
-    return mParams->ForEach(aIterator);
-
-    return true;
-  }
-
   bool
   ReadStructuredClone(JSStructuredCloneReader* aReader);
 
   bool
   WriteStructuredClone(JSStructuredCloneWriter* aWriter) const;
 
 private:
   void AppendInternal(const nsAString& aName, const nsAString& aValue);