Bug 1484147 [wpt PR 12542] - Modify source path for wpt test of Accept-CH, a=testonly
authorYuki Yamada <yukiy@google.com>
Fri, 24 Aug 2018 13:06:42 +0000
changeset 491640 3af7f616edddb57d25349330091f27bffad13a91
parent 491639 33593424f5016a2a7dae3460c0e6c791e9aaa7a7
child 491641 aa86af0c5b945ed0a387ff36428b1807ec13c28c
push id1815
push userffxbld-merge
push dateMon, 15 Oct 2018 10:40:45 +0000
treeherdermozilla-release@18d4c09e9378 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1484147, 12542, 1179511, 584958
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1484147 [wpt PR 12542] - Modify source path for wpt test of Accept-CH, a=testonly Automatic update from web-platform-testsModify source path for wpt test of Accept-CH This CL modifies source path that is used in wpt test of Accept-CH. window.open() uses the base URL of the entry realm's window in order to resolve a relative URL. The entry realm should be main window on calling function |acceptChLoaded| as a listener for load event of non-main window in this test. We want to open do_not_expect_client_hints_headers.html in resources/ so the relative URL in this test should start from "resources/". Also, entry realm is not set correctly by current chromium implementation, so fixed test is assumed to fail. Change-Id: I973393e0a7ca74cac882eb58f5a58aa9a81556ff Reviewed-on: https://chromium-review.googlesource.com/1179511 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#584958} -- wpt-commits: cd356d332be2a1edb92ae8bb185d0ff3fb40a176 wpt-pr: 12542
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/client-hints/accept_ch.tentative.https.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -434858,17 +434858,17 @@
    "50d77646f89aea13c212c6ecee4e7f32107007e9",
    "testharness"
   ],
   "client-hints/accept_ch.http.html.headers": [
    "4f3a57b865b8b58fd5c037976880de8e6cc184da",
    "support"
   ],
   "client-hints/accept_ch.tentative.https.html": [
-   "b8379de46a22062f626164a050fe28549da0082d",
+   "491ef3c71873bdc349be28deda2a3b455b10da78",
    "testharness"
   ],
   "client-hints/accept_ch.tentative.sub.https.html": [
    "43c1fb12c2005e08b75f7cdfb24e6ad1a90ead1a",
    "testharness"
   ],
   "client-hints/accept_ch.tentative.sub.https.html.headers": [
    "4f3a57b865b8b58fd5c037976880de8e6cc184da",
--- a/testing/web-platform/tests/client-hints/accept_ch.tentative.https.html
+++ b/testing/web-platform/tests/client-hints/accept_ch.tentative.https.html
@@ -47,17 +47,17 @@ async_test(t => {
     assert_equals(e.data, "PASS");
     t.done();
   })
 }, "Loading of resources/do_not_expect_client_hints_headers.html did not finish.");
 
 function acceptChLoaded() {
   // Open a new window. Verify that the user agent does not attach the client
   // hints.
-  var verify_win = window.open("do_not_expect_client_hints_headers.html");
+  var verify_win = window.open("resources/do_not_expect_client_hints_headers.html");
   assert_not_equals(verify_win, null, "Popup windows not allowed?");
 }
 
 // Fetching this webpage should NOT cause user-agent to persist client hint
 // preferences for the origin.
 var win = window.open("resources/accept_ch.html");
 assert_not_equals(win, null, "Popup windows not allowed?");
 win.addEventListener('load', acceptChLoaded, false);