Bug 1512737 - Assign HRTF to panningModel attribute instead of adding type property. r=padenot, a=test-only
authorKarl Tomlinson <karlt+@karlt.net>
Mon, 07 Jan 2019 08:51:31 +0000
changeset 509363 39fe709c6cf8de41c2a739ad456877eb5fa1e7c3
parent 509362 0f838be24568f673a5bea33acfd9cce27beed623
child 509364 c777b4b5cd07b6575bacf5a2309b384c0c7c9c6f
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspadenot, test-only
bugs1512737
milestone65.0
Bug 1512737 - Assign HRTF to panningModel attribute instead of adding type property. r=padenot, a=test-only Differential Revision: https://phabricator.services.mozilla.com/D14494
dom/media/webaudio/test/test_pannerNodeHRTFSymmetry.html
dom/media/webaudio/test/test_pannerNodeTail.html
--- a/dom/media/webaudio/test/test_pannerNodeHRTFSymmetry.html
+++ b/dom/media/webaudio/test/test_pannerNodeHRTFSymmetry.html
@@ -24,18 +24,18 @@ function isChannelSilent(channel) {
     }
   }
   return true;
 }
 
 function startTest() {
   var leftPanner = ctx.createPanner();
   var rightPanner = ctx.createPanner();
-  leftPanner.type = "HRTF";
-  rightPanner.type = "HRTF";
+  leftPanner.panningModel = "HRTF";
+  rightPanner.panningModel = "HRTF";
   leftPanner.positionX.value = -1;
   rightPanner.positionX.value = 1;
 
   // Test that PannerNode processes the signal consistently irrespective of
   // the offset in the processing block.  This is done by inserting a delay of
   // less than a block size before one panner.
   const delayTime = 0.7 * blockSize / ctx.sampleRate;
   var leftDelay = ctx.createDelay(delayTime);
--- a/dom/media/webaudio/test/test_pannerNodeTail.html
+++ b/dom/media/webaudio/test/test_pannerNodeTail.html
@@ -171,17 +171,17 @@ function startTest() {
 
   for (var i = 0; i < pannerCount; ++i) {
     var delay = ctx.createDelay(delayDuration);
     delay.delayTime.value = delayDuration;
     source.connect(delay);
     delay.connect(referencePanner)
 
     var panner = ctx.createPanner();
-    panner.type = "HRTF";
+    panner.panningModel = "HRTF";
     delay.connect(panner);
     testPanners[i] = panner;
 
     delayDuration += blockSize / ctx.sampleRate;
   }
 
   // Create a ScriptProcessor now to use as a timer to trigger connection of
   // downstream nodes.  It will also be used to record reference output.
@@ -203,17 +203,17 @@ function prepareTest() {
   // Place the listener to the side of the origin, where the panners are
   // positioned, to maximize delay in one ear.
   ctx.listener.setPosition(1,0,0);
 
   // A PannerNode will produce no output until it has loaded its HRIR
   // database.  Wait for this to load before starting the test.
   var processor = ctx.createScriptProcessor(bufferSize, 2, 0);
   referencePanner = ctx.createPanner();
-  referencePanner.type = "HRTF";
+  referencePanner.panningModel = "HRTF";
   referencePanner.connect(processor);
   var oscillator = ctx.createOscillator();
   oscillator.connect(referencePanner);
   oscillator.start(0);
 
   processor.onaudioprocess = function(e) {
     if (isChannelSilent(e.inputBuffer.getChannelData(0)))
       return;