Bug 1350887 - Propagate errors thrown when starting server.TCPListener; r=whimboo, a=test-only
authorAndreas Tolfsen <ato@mozilla.com>
Tue, 28 Mar 2017 16:48:20 +0100
changeset 395692 39f487bdf0a3cafd1f19d63f52b6ea3205361523
parent 395691 684f78299750cac7dbf62ea619a5417675c8519a
child 395693 4ab26e8674260f8a1e4dc89c1e10efa2ba544c9b
push id1468
push userasasaki@mozilla.com
push dateMon, 05 Jun 2017 19:31:07 +0000
treeherdermozilla-release@0641fc6ee9d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerswhimboo, test-only
bugs1350887
milestone54.0a2
Bug 1350887 - Propagate errors thrown when starting server.TCPListener; r=whimboo, a=test-only Errors thrown are printed to console and there is no point in having a custom catch to print it. This also makes it possible to start Marionette programmatically without worrying about disappearing errors. MozReview-Commit-ID: GGhyCyYqJg
testing/marionette/components/marionette.js
--- a/testing/marionette/components/marionette.js
+++ b/testing/marionette/components/marionette.js
@@ -292,19 +292,16 @@ MarionetteComponent.prototype.init = fun
   }
 
   let s;
   try {
     Cu.import("chrome://marionette/content/server.js");
     s = new server.TCPListener(prefs.port, prefs.forceLocal);
     s.start();
     this.logger.info(`Listening on port ${s.port}`);
-  } catch (e) {
-    this.logger.error(`Error on starting server: ${e}`);
-    dump(`${e.toString()}\n${e.stack}\n`);
   } finally {
     if (s) {
       this.server = s;
       this.running = true;
     }
   }
 };