Bug 1215455 - eslint operator-assignment [r=Standard8]
authorEd Lee <edilee@mozilla.com>
Fri, 16 Oct 2015 17:12:02 -0700
changeset 304186 39f32e5b6af91d4d7a63f332a472e05d09a2f5de
parent 304185 d39db1517fb2fbbbe14c11c71e2beb871725074a
child 304187 2eb2b6388613a26f581f7339ea1d8c4082abf3f2
push id1001
push userraliiev@mozilla.com
push dateMon, 18 Jan 2016 19:06:03 +0000
treeherdermozilla-release@8b89261f3ac4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersStandard8
bugs1215455
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1215455 - eslint operator-assignment [r=Standard8]
browser/components/loop/.eslintrc
browser/components/loop/ui/ui-showcase.js
browser/components/loop/ui/ui-showcase.jsx
--- a/browser/components/loop/.eslintrc
+++ b/browser/components/loop/.eslintrc
@@ -96,16 +96,17 @@
     "no-unexpected-multiline": 2,
     "no-unneeded-ternary": 2,
     "no-unused-expressions": 0,   // TODO: Set to 2
     "no-unused-vars": 0,          // TODO: Set to 2
     "no-use-before-define": 0,    // TODO: Set to 2
     "no-useless-call": 2,
     "no-with": 2,
     "object-curly-spacing": [2, "always"],
+    "operator-assignment": [2, "always"],
     "quotes": [2, "double", "avoid-escape"],
     "semi": 2,
     "semi-spacing": [2, {"before": false, "after": true}],
     "space-after-keywords": 2,
     "space-before-blocks": 2,
     "space-before-function-paren": [2, "never"],
     "space-before-keywords": 2,
     "space-infix-ops": 2,
--- a/browser/components/loop/ui/ui-showcase.js
+++ b/browser/components/loop/ui/ui-showcase.js
@@ -1353,27 +1353,27 @@
 
         divFailuresNode.className = "failures";
         emNode.innerHTML = ((uncaughtError && warningsMismatch) ? 2 : 1).toString();
         divFailuresNode.appendChild(emNode);
         resultsElement.appendChild(divFailuresNode);
 
         if (warningsMismatch) {
           liTestFail.className = "test";
-          liTestFail.className = liTestFail.className + " fail";
+          liTestFail.className += " fail";
           h2Node.innerHTML = "Unexpected number of warnings detected in UI-Showcase";
           preErrorNode.className = "error";
           preErrorNode.innerHTML = "Got: " + caughtWarnings.length + "\n" + "Expected: " + expectedWarningsCount;
           liTestFail.appendChild(h2Node);
           liTestFail.appendChild(preErrorNode);
           resultsElement.appendChild(liTestFail);
         }
         if (uncaughtError) {
           liTestFail.className = "test";
-          liTestFail.className = liTestFail.className + " fail";
+          liTestFail.className += " fail";
           h2Node.innerHTML = "Errors rendering UI-Showcase";
           preErrorNode.className = "error";
           preErrorNode.innerHTML = uncaughtError + "\n" + uncaughtError.stack;
           liTestFail.appendChild(h2Node);
           liTestFail.appendChild(preErrorNode);
           resultsElement.appendChild(liTestFail);
         }
       } else {
--- a/browser/components/loop/ui/ui-showcase.jsx
+++ b/browser/components/loop/ui/ui-showcase.jsx
@@ -1353,27 +1353,27 @@
 
         divFailuresNode.className = "failures";
         emNode.innerHTML = ((uncaughtError && warningsMismatch) ? 2 : 1).toString();
         divFailuresNode.appendChild(emNode);
         resultsElement.appendChild(divFailuresNode);
 
         if (warningsMismatch) {
           liTestFail.className = "test";
-          liTestFail.className = liTestFail.className + " fail";
+          liTestFail.className += " fail";
           h2Node.innerHTML = "Unexpected number of warnings detected in UI-Showcase";
           preErrorNode.className = "error";
           preErrorNode.innerHTML = "Got: " + caughtWarnings.length + "\n" + "Expected: " + expectedWarningsCount;
           liTestFail.appendChild(h2Node);
           liTestFail.appendChild(preErrorNode);
           resultsElement.appendChild(liTestFail);
         }
         if (uncaughtError) {
           liTestFail.className = "test";
-          liTestFail.className = liTestFail.className + " fail";
+          liTestFail.className += " fail";
           h2Node.innerHTML = "Errors rendering UI-Showcase";
           preErrorNode.className = "error";
           preErrorNode.innerHTML = uncaughtError + "\n" + uncaughtError.stack;
           liTestFail.appendChild(h2Node);
           liTestFail.appendChild(preErrorNode);
           resultsElement.appendChild(liTestFail);
         }
       } else {