Bug 1401085 - Make the opacity of the disabled back button consistent with other disabled toolbar buttons. r=dao, a=sledru
authorNihanth Subramanya <nhnt11@gmail.com>
Thu, 21 Sep 2017 05:12:59 +0530
changeset 434331 38f4bb54aa797c90303ded0863fe6a2f153ba290
parent 434330 a99eb3b7ac5a24d3fd63689a4da7d937f4a69117
child 434332 2324642ef3dbe0dacd502ff2e7bf02a62faa32c5
push id1567
push userjlorenzo@mozilla.com
push dateThu, 02 Nov 2017 12:36:05 +0000
treeherdermozilla-release@e512c14a0406 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao, sledru
bugs1401085
milestone57.0
Bug 1401085 - Make the opacity of the disabled back button consistent with other disabled toolbar buttons. r=dao, a=sledru MozReview-Commit-ID: Lun7GjOZhmy
browser/themes/osx/browser.css
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -316,20 +316,24 @@
 .findbar-button {
   background: none;
   box-shadow: none;
   border: none;
 }
 
 /* On Mac, native buttons keep their full opacity when they become disabled
  * and only the glyph or text on top of them becomes less opaque. */
-#back-button[disabled="true"] > .toolbarbutton-icon {
+#main-window:not([customizing]) #back-button[disabled="true"] > .toolbarbutton-icon {
   opacity: 1 !important;
   -moz-context-properties: fill, fill-opacity;
-  fill-opacity: 0.4;
+  /* Disabled toolbar buttons get an opacity of 0.4 which multiplies
+   * their fill-opacity of 0.7. calc() doesn't work here - we'd need
+   * to multiply two unitless numbers and that's invalid in CSS, so
+   * we need to hard code the value for now. */
+  fill-opacity: 0.28;
 }
 
 /* Inactive elements are faded out on OSX */
 .toolbarbutton-1:not(:hover):-moz-window-inactive,
 #main-window:not([customizing]) .toolbarbutton-1:-moz-window-inactive[disabled="true"] {
   opacity: 0.5;
 }