Bug 1500251 - Add dummy pref with default value true, report via telemetry. r=mythmon
authorChris Pearce <cpearce@mozilla.com>
Thu, 18 Oct 2018 22:02:52 +0000
changeset 500463 38c1fc84fcaf42dbbdf53f286a0878cbadb0dbaf
parent 500462 7d3a598c12859f4bed3fc560bad3ae37af5f272a
child 500464 8dd09fad1f352d3814244908f0ea04f29fa2a307
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmythmon
bugs1500251, 1499552
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1500251 - Add dummy pref with default value true, report via telemetry. r=mythmon The Webrender Pref Experiment is reporting its pref via telemetry and that is reporting a different value than what the Normandy experiments telemetry indicates should be being seen. In Bug 1499552 I added a pref and telemetry reporting in preparation for running a dummy Pref Experiment to verify that prefs set are reported as set, but I realised I missed a case; where there's an existing default pref set, we're only covering the case where that default pref has value false. We're seeing a ~25% failure rate in the pref reporting. So we should cover the other three cases in the dummy Pref Experiment, just in case it's one of these four cases that is failing. So here I add another dummy pref with a default value of true, and I report that via telemetry. I rename the pref I added yesterday to make things consistent. Differential Revision: https://phabricator.services.mozilla.com/D9156
modules/libpref/init/all.js
toolkit/components/telemetry/app/TelemetryEnvironment.jsm
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -5936,10 +5936,11 @@ pref("dom.datatransfer.mozAtAPIs", true)
 // Whether or not Prio is supported on this platform.
 #ifdef MOZ_LIBPRIO
 pref("prio.enabled", false);
 #endif
 
 #ifdef NIGHTLY_BUILD
 // Bug 1499552; add a dummy pref to verify that collection of preferences
 // via telemetry is working as expected.
-pref("app.normandy.test.with_default", false);
+pref("app.normandy.test.with_true_default", true);
+pref("app.normandy.test.with_false_default", false);
 #endif
--- a/toolkit/components/telemetry/app/TelemetryEnvironment.jsm
+++ b/toolkit/components/telemetry/app/TelemetryEnvironment.jsm
@@ -178,17 +178,18 @@ const RECORD_PREF_STATE = TelemetryEnvir
 const RECORD_PREF_VALUE = TelemetryEnvironment.RECORD_PREF_VALUE;
 const RECORD_DEFAULTPREF_VALUE = TelemetryEnvironment.RECORD_DEFAULTPREF_VALUE;
 const RECORD_DEFAULTPREF_STATE = TelemetryEnvironment.RECORD_DEFAULTPREF_STATE;
 const DEFAULT_ENVIRONMENT_PREFS = new Map([
   ["app.feedback.baseURL", {what: RECORD_PREF_VALUE}],
   ["app.support.baseURL", {what: RECORD_PREF_VALUE}],
   ["accessibility.browsewithcaret", {what: RECORD_PREF_VALUE}],
   ["accessibility.force_disabled", {what:  RECORD_PREF_VALUE}],
-  ["app.normandy.test.with_default", {what: RECORD_PREF_VALUE}],
+  ["app.normandy.test.with_true_default", {what: RECORD_PREF_VALUE}],
+  ["app.normandy.test.with_false_default", {what: RECORD_PREF_VALUE}],
   ["app.normandy.test.without_default", {what: RECORD_PREF_VALUE}],
   ["app.shield.optoutstudies.enabled", {what: RECORD_PREF_VALUE}],
   ["app.update.auto", {what: RECORD_PREF_VALUE}],
   ["app.update.interval", {what: RECORD_PREF_VALUE}],
   ["app.update.service.enabled", {what: RECORD_PREF_VALUE}],
   ["app.update.silent", {what: RECORD_PREF_VALUE}],
   ["app.update.url", {what: RECORD_PREF_VALUE}],
   ["browser.cache.disk.enable", {what: RECORD_PREF_VALUE}],