Bug 1217003 - Tabs tray (List): Use different text color and close button style if tab is selected. r=margaret
authorSebastian Kaspari <s.kaspari@gmail.com>
Thu, 22 Oct 2015 12:30:54 +0200
changeset 304324 38c141f004293a4f6d8aca5f2d0ef61881e3b9c0
parent 304323 90640aec2ec03546cacdbda9b1824a5e9484551c
child 304325 e96850747f864d83ab1871510194504f9d5a596c
push id1001
push userraliiev@mozilla.com
push dateMon, 18 Jan 2016 19:06:03 +0000
treeherdermozilla-release@8b89261f3ac4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmargaret
bugs1217003
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1217003 - Tabs tray (List): Use different text color and close button style if tab is selected. r=margaret This will create feature parity with the look & feel of tabs in the grid view.
mobile/android/base/resources/layout/tabs_list_item_view.xml
--- a/mobile/android/base/resources/layout/tabs_list_item_view.xml
+++ b/mobile/android/base/resources/layout/tabs_list_item_view.xml
@@ -30,35 +30,37 @@
     </org.mozilla.gecko.widget.TabThumbnailWrapper>
 
     <LinearLayout android:layout_width="0dip"
                   android:layout_height="match_parent"
                   android:orientation="vertical"
                   android:layout_weight="1.0"
                   android:paddingTop="4dip"
                   android:paddingLeft="8dip"
-                  android:paddingRight="4dip">
+                  android:paddingRight="4dip"
+                  android:duplicateParentState="true">
 
         <TextView android:id="@+id/title"
                   android:layout_width="match_parent"
                   android:layout_height="0dip"
                   android:layout_weight="1.0"
                   style="@style/TabLayoutItemTextAppearance"
-                  android:textColor="#FFFFFFFF"
+                  android:textColor="@color/tab_item_title"
                   android:textSize="14sp"
                   android:gravity="center_vertical"
                   android:singleLine="false"
                   android:maxLines="4"
                   android:drawablePadding="6dp"
                   android:duplicateParentState="true"/>
 
     </LinearLayout>
 
     <ImageButton android:id="@+id/close"
                  style="@style/TabsItemClose"
                  android:layout_width="34dip"
                  android:layout_height="match_parent"
                  android:background="@drawable/action_bar_button_inverse"
                  android:scaleType="center"
                  android:contentDescription="@string/close_tab"
-                 android:src="@drawable/tab_close"/>
+                 android:src="@drawable/tab_item_close_button"
+                 android:duplicateParentState="true"/>
 
 </org.mozilla.gecko.tabs.TabsLayoutItemView>
\ No newline at end of file