Bug 1376873 - Make lock_block explicit; r=bwc
☠☠ backed out by 63f135d2db22 ☠ ☠
authorDan Minor <dminor@mozilla.com>
Thu, 02 Aug 2018 13:56:10 -0400
changeset 503475 381df4c6ae88907382b3fa10ca1a6ccae3a12bc8
parent 503474 acc06acb5342569c9a5c78208c63eafd45880d62
child 503476 0c3c2fc4646b61c4634f232ef193cc45a85dd22c
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbwc
bugs1376873
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1376873 - Make lock_block explicit; r=bwc Differential Revision: https://phabricator.services.mozilla.com/D7468
media/mtransport/sigslot.h
--- a/media/mtransport/sigslot.h
+++ b/media/mtransport/sigslot.h
@@ -207,17 +207,17 @@ class multi_threaded_local {
 };
 #endif  // _SIGSLOT_HAS_POSIX_THREADS
 
 template <class mt_policy>
 class lock_block {
  public:
   mt_policy* m_mutex;
 
-  lock_block(mt_policy* mtx) : m_mutex(mtx) { m_mutex->lock(); }
+  explicit lock_block(mt_policy* mtx) : m_mutex(mtx) { m_mutex->lock(); }
 
   ~lock_block() { m_mutex->unlock(); }
 };
 
 class _signal_base_interface;
 
 class has_slots_interface {
  private: