Backed out changeset 3f521a9d4d1f (bug 1273634)
authorCarsten "Tomcat" Book <cbook@mozilla.com>
Thu, 02 Jun 2016 15:05:00 +0200
changeset 341072 379f4fff66d54866353e62f184d54cd399b7445d
parent 341071 34a8be4346a9231e472fc36b1d7c0531e0fbf7c5
child 341073 d8fb9ee64c5c7772e967d41dfcde38be2e9ea325
push id1183
push userraliiev@mozilla.com
push dateMon, 05 Sep 2016 20:01:49 +0000
treeherdermozilla-release@3148731bed45 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1273634
milestone49.0a1
backs out3f521a9d4d1f4f553266f54469f009245a1d4b2e
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 3f521a9d4d1f (bug 1273634)
testing/taskcluster/tasks/branches/base_jobs.yml
testing/taskcluster/tasks/tests/mozlint-flake8.yml
tools/lint/mach_commands.py
--- a/testing/taskcluster/tasks/branches/base_jobs.yml
+++ b/testing/taskcluster/tasks/branches/base_jobs.yml
@@ -521,26 +521,16 @@ tasks:
         # Run when eslint policies change.
         - '**/.eslintignore'
         - '**/*eslintrc*'
         # The plugin implementing custom checks.
         - 'testing/eslint/eslint-plugin-mozilla/**'
         # Other misc lint related files.
         - 'tools/lint/**'
         - 'testing/docker/lint/**'
-  flake8-gecko:
-    task: tasks/tests/mozlint-flake8.yml
-    root: true
-    when:
-      file_patterns:
-        - '**/*.py'
-        - '**/.flake8'
-        - 'python/mozlint/**'
-        - 'tools/lint/**'
-        - 'testing/docker/lint/**'
   android-api-15-gradle-dependencies:
     task: tasks/builds/android_api_15_gradle_dependencies.yml
     root: true
     when:
       file_patterns:
         - 'mobile/android/config/**'
         - 'testing/docker/android-gradle-build/**'
         - 'testing/mozharness/configs/builds/releng_sub_android_configs/*gradle_dependencies.py'
deleted file mode 100644
--- a/testing/taskcluster/tasks/tests/mozlint-flake8.yml
+++ /dev/null
@@ -1,37 +0,0 @@
----
-$inherits:
-  from: 'tasks/lint.yml'
-  variables:
-    build_product: 'lint'
-    build_name: 'flake8-gecko'
-    build_type: 'opt'
-
-task:
-  metadata:
-    name: '[TC] - Flake8'
-    description: 'Python flake8 linter'
-  payload:
-    image:
-      type: 'task-image'
-      path: 'public/image.tar'
-      taskId: '{{#task_id_for_image}}lint{{/task_id_for_image}}'
-    command:
-      - bash
-      - -cx
-      - >
-          tc-vcs checkout ./gecko {{base_repository}} {{head_repository}} {{head_rev}} {{head_ref}} &&
-          cd gecko &&
-          ./mach lint -l flake8 -f treeherder
-  extra:
-    locations:
-      build: null
-      tests: null
-    treeherder:
-      machine:
-        platform: lint
-      groupSymbol: tc
-      symbol: f8
-      tier: 2
-    treeherderEnv:
-      - production
-      - staging
--- a/tools/lint/mach_commands.py
+++ b/tools/lint/mach_commands.py
@@ -50,23 +50,18 @@ class MachCommands(MachCommandBase):
 
         lintargs['exclude'] = ['obj*']
         lint = LintRoller(**lintargs)
         lint.read(lint_files)
 
         # run all linters
         results = lint.roll(paths)
 
-        status = 0
-        if results:
-            status = 1
-
         formatter = formatters.get(fmt)
         print(formatter(results))
-        return status
 
     @SubCommand('lint', 'setup',
                 "Setup required libraries for specified lints.")
     @CommandArgument(
         '-l', '--linter', dest='linters', default=None, action='append',
         help="Linters to run, e.g 'eslint'. By default all linters are run "
              "for all the appropriate files.")
     def lint_setup(self, linters=None, **lintargs):