mozilla-release: changeset 453608:373c9a71d9451498462594b302b4fe2648431fef

author	Nick Alexander <nalexander@mozilla.com>
	Tue, 07 Nov 2017 20:24:04 -0800
changeset 453608	373c9a71d9451498462594b302b4fe2648431fef
parent 453607	3dc3beab95f83b2f08ff9ff305fdd4b85cc05d9d
child 453609	901b304603d9d4816856d560c61387501efceadc
push id	1648
push user	mtabara@mozilla.com
push date	Thu, 01 Mar 2018 12:45:47 +0000
treeherder	mozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	mcomella
bugs	1411654
milestone	59.0a1
first release with	nightly linux32 e4107773cffb / 59.0a1 / 20180116100114 / files nightly linux64 e4107773cffb / 59.0a1 / 20180116100114 / files nightly mac e4107773cffb / 59.0a1 / 20180116100114 / files nightly win32 e4107773cffb / 59.0a1 / 20180116100114 / files nightly win64 e4107773cffb / 59.0a1 / 20180116100114 / files
last release without	nightly linux32 b7d66e4e60ef / 59.0a1 / 20180115100056 / files nightly linux64 b7d66e4e60ef / 59.0a1 / 20180115100056 / files nightly mac b7d66e4e60ef / 59.0a1 / 20180115100056 / files nightly win32 b7d66e4e60ef / 59.0a1 / 20180115100056 / files nightly win64 b7d66e4e60ef / 59.0a1 / 20180115100056 / files

Bug 1411654 - Pre: Clear icon disk storage in test. r=mcomella Newer versions of Robolectric seem to have different semantics about clearing disk caches, so this is necessary. But for older versions, it shouldn't hurt, and is slightly more clear than relying on an implicit clear. MozReview-Commit-ID: LRcaEPasXj8

mobile/android/app/src/test/java/org/mozilla/gecko/icons/preparation/TestLookupIconUrl.java

file | annotate | diff | comparison | revisions

--- a/mobile/android/app/src/test/java/org/mozilla/gecko/icons/preparation/TestLookupIconUrl.java
+++ b/mobile/android/app/src/test/java/org/mozilla/gecko/icons/preparation/TestLookupIconUrl.java
@@ -23,16 +23,17 @@ public class TestLookupIconUrl {
     private static final String TEST_ICON_URL_2 = "http://example.org/favicon.ico";
     private static final String TEST_ICON_URL_3 = "http://example.com/favicon.ico";
     private static final String TEST_ICON_URL_4 = "http://example.net/favicon.ico";
 
 
     @Before
     public void setUp() {
         MemoryStorage.get().evictAll();
+        DiskStorage.get(RuntimeEnvironment.application).evictAll();
     }
 
     @Test
     public void testNoIconUrlIsAddedByDefault() {
         final IconRequest request = Icons.with(RuntimeEnvironment.application)
                 .pageUrl(TEST_PAGE_URL)
                 .build();