Bug 1321412 - Fix a bug in the definition of SizeTyped. r=kats
☠☠ backed out by 284e73444c60 ☠ ☠
authorBotond Ballo <botond@mozilla.com>
Wed, 23 Nov 2016 19:26:55 -0500
changeset 372782 34a1640010d698cb36b2ca74e4b0fffcdda6d4eb
parent 372781 a3fe137d4d47d0d8c897bcb81d6ed1201a5dde89
child 372783 31f15a3b5ce0e02ce66d7ed04fa6055853749d20
push id1419
push userjlund@mozilla.com
push dateMon, 10 Apr 2017 20:44:07 +0000
treeherdermozilla-release@5e6801b73ef6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskats
bugs1321412
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1321412 - Fix a bug in the definition of SizeTyped. r=kats A second template parameter 'F' was previously added to SizeTyped, but was not correspondingly added to the argument passed for the 'Sub' parameter of BaseSize. MozReview-Commit-ID: 2pRQXeWMJpP
gfx/2d/Point.h
--- a/gfx/2d/Point.h
+++ b/gfx/2d/Point.h
@@ -280,17 +280,17 @@ struct IntSizeTyped :
   IntSizeTyped<UnknownUnits> ToUnknownSize() const {
     return IntSizeTyped<UnknownUnits>(this->width, this->height);
   }
 };
 typedef IntSizeTyped<UnknownUnits> IntSize;
 
 template<class units, class F = Float>
 struct SizeTyped :
-  public BaseSize< F, SizeTyped<units> >,
+  public BaseSize< F, SizeTyped<units, F> >,
   public units {
   static_assert(IsPixel<units>::value,
                 "'units' must be a coordinate system tag");
 
   typedef BaseSize< F, SizeTyped<units, F> > Super;
 
   constexpr SizeTyped() : Super() {}
   constexpr SizeTyped(F aWidth, F aHeight) : Super(aWidth, aHeight) {}