Bug 1292355 - firefox-ui-tests should upload minidump files as artifacts. r=maja_zf a=testonly
authorHenrik Skupin <mail@hskupin.info>
Fri, 12 Aug 2016 14:23:13 +0200
changeset 349859 3443b3c753233c7ea260b09366b4b28ac2c4525a
parent 349858 2a0981531355dc77614e72c72fda7498bb074ffe
child 349860 7b44f5b3b0bb503b79166ac861b1f3f9c1f8abb9
push id1230
push userjlund@mozilla.com
push dateMon, 31 Oct 2016 18:13:35 +0000
treeherdermozilla-release@5e06e3766db2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmaja_zf, testonly
bugs1292355
milestone50.0a2
Bug 1292355 - firefox-ui-tests should upload minidump files as artifacts. r=maja_zf a=testonly MozReview-Commit-ID: EzN3wbuT5PN
testing/mozharness/mozharness/mozilla/testing/firefox_ui_tests.py
--- a/testing/mozharness/mozharness/mozilla/testing/firefox_ui_tests.py
+++ b/testing/mozharness/mozharness/mozilla/testing/firefox_ui_tests.py
@@ -251,36 +251,36 @@ class FirefoxUITests(TestingMixin, VCSTo
 
         # Collect all pass-through harness options to the script
         cmd.extend(self.query_harness_args())
 
         # Translate deprecated --e10s flag
         if not self.config.get('e10s'):
             cmd.append('--disable-e10s')
 
-        # Set further environment settings
-        env = env or self.query_env()
-
         if self.symbols_url:
             cmd.extend(['--symbols-path', self.symbols_url])
 
-        if self.query_minidump_stackwalk():
-            env['MINIDUMP_STACKWALK'] = self.minidump_stackwalk_path
-
         if self.config.get('tag'):
             cmd.extend(['--tag', self.config['tag']])
 
         parser = StructuredOutputParser(config=self.config,
                                         log_obj=self.log_obj,
                                         strict=False)
 
         # Add the default tests to run
         tests = [os.path.join(dirs['abs_fxui_dir'], 'tests', test) for test in self.default_tests]
         cmd.extend(tests)
 
+        # Set further environment settings
+        env = env or self.query_env()
+        env.update({'MINIDUMP_SAVE_PATH': dirs['abs_blob_upload_dir']})
+        if self.query_minidump_stackwalk():
+            env.update({'MINIDUMP_STACKWALK': self.minidump_stackwalk_path})
+
         return_code = self.run_command(cmd,
                                        cwd=dirs['abs_work_dir'],
                                        output_timeout=300,
                                        output_parser=parser,
                                        env=env)
 
         tbpl_status, log_level = parser.evaluate_parser(return_code)
         self.buildbot_status(tbpl_status, level=log_level)