Bug 1437067 [wpt PR 9400] - [css-align] justfy-items accepts 'legacy' and drops support for 'auto', a=testonly
☠☠ backed out by a6a32fb286fa ☠ ☠
authorJavier Fernandez <jfernandez@igalia.com>
Tue, 06 Mar 2018 18:37:18 +0000
changeset 461976 340be2f71abf82d0de28870cdfa987e0e309e267
parent 461975 fd8dcd647f0e5ae4746b9667517293a0a0115d02
child 461977 09992ffb6a0deaf34ee542a196dc814b08b622ed
push id1683
push usersfraser@mozilla.com
push dateThu, 26 Apr 2018 16:43:40 +0000
treeherdermozilla-release@5af6cb21869d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1437067, 726147, 726148, 903162, 535593
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1437067 [wpt PR 9400] - [css-align] justfy-items accepts 'legacy' and drops support for 'auto', a=testonly Automatic update from web-platform-tests The syntax of the 'justify-items' property accepts a new 'legacy' value, replacing the 'auto' value which is now parsed as invalid. https://github.com/w3c/csswg-drafts/issues/1318 This change affects also to the 'place-items' shorthand, which doesn't accept 'auto' and, for the time being, neither 'legacy'. Link to the intent-to-ship-and-remove request: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/552753c1-9b2f-bb01-4fed-2ae621f2398e%40igalia.com?utm_medium=email&utm_source=footer Bug: 726147, 726148 Change-Id: I219de66b813d350fe33f00a1d4369bed8e9a2350 Reviewed-on: https://chromium-review.googlesource.com/903162 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#535593} <!-- Reviewable:start --> <!-- Reviewable:end --> wpt-commits: 6d85a3b422cab97d032ad3db47cb741ca364185f wpt-pr: 9400 reapplied-commits: 370e267e160568862f1fd9ec246ab5bb840f586e, fe4514c84e7ad28e46bad5da93381deb99b177f3, 7806af854343c043a2645a4034fdc7812f65daad, 9ddfd21554293dec5a4bf2e5375ae4f3c9f2ded0, 75f63c4d1ebc949647184fd60972fc7b9fd4affb, 1f3a5b496acd2288cc8cf0c32af86cb35157ea4e, 88b42bd5847abac58a62c4d6b33c1509bfce5f3d, 15c2e4c690700c6c115f8afe5e44ded10d943538, c8d461ef1437641ae7d4ea1d21e1e60cd62910b0, a6088a5f48ee299386a84d2f771902267d7355b1, 0634cd8f08ebe0905a9188fb1398c7b5f889c5dc, c8ee4a012dae506ae06bb5b2ad50942b04c1aaaa, c2c352456a4cf62dcc12f851138b04397675a445, b93a8879555d2fa7e7d4e00a275513a3a6338b35, b86e1331cb36634fd33677043b61fc0c1d8485bc, 44ddf14fd3346658c3223f13652073fafbfa48fa, a1a5840a6bb53e305ba02bcbeb215659342d0edb, 7465cb110ae5ec2e2ca73182caf5293f0efc8fd5, aad5349b3458bc3414e274b33fa86a1123901ff2, eca0907980d2769c449894a6277c60c1a306792f, 38626987c0cfd6e715cfcc6f4f1a1209191a03c5, e4a67f7ddcde6cd99348e9104bd7ed07074da44a, bb3c9990840a0fae2afc840b5952d7874785b112, 042d7adef0bdb9dc80e825c3997ace7519477c42, 99f1ea44fc7915b8b7b33bce4732fa8765fd3ac2, b81999f30c1516a70c153de51a0331d14c8faead
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/css-align/content-distribution/place-content-shorthand-004.html
testing/web-platform/tests/css/css-align/default-alignment/parse-justify-items-002.html
testing/web-platform/tests/css/css-align/default-alignment/place-items-shorthand-004.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -475791,17 +475791,17 @@
    "f5f4f2279506dc6106de38080a639979ad7e05d0",
    "testharness"
   ],
   "css/css-align/content-distribution/place-content-shorthand-003.html": [
    "966e8dd3893c487b02bb139ac26862995b655603",
    "testharness"
   ],
   "css/css-align/content-distribution/place-content-shorthand-004.html": [
-   "5aa5cda5b2b0204bd2deb5c813532f394644b31f",
+   "17c135945710d209b2e410d36867f6244ac358a0",
    "testharness"
   ],
   "css/css-align/content-distribution/place-content-shorthand-005.html": [
    "6b3d7b9ae7d5b28510385cccaaade09268409cab",
    "testharness"
   ],
   "css/css-align/content-distribution/place-content-shorthand-006.html": [
    "a40c054505716dda72b642ada40d8796a5d68795",
@@ -475839,17 +475839,17 @@
    "e5b9aed617b086152a25ffb4b3a39a8898a3622e",
    "testharness"
   ],
   "css/css-align/default-alignment/parse-justify-items-001.html": [
    "a60f7ed4a16ad9e6c12c8004b90bb1f88083af31",
    "testharness"
   ],
   "css/css-align/default-alignment/parse-justify-items-002.html": [
-   "b74652a3770f5bf8b7184748d62a21625f9121b3",
+   "12902e19304a7f02a52c576f3daf72fd9eb45ff8",
    "testharness"
   ],
   "css/css-align/default-alignment/parse-justify-items-003.html": [
    "3a66f7c4d618f0ea0ff112ac7dce8e5d6257084a",
    "testharness"
   ],
   "css/css-align/default-alignment/parse-justify-items-004.html": [
    "e2e61304ecccb8f0892eebb0eda6b510287174a6",
@@ -475871,17 +475871,17 @@
    "a087659c5fa60012fa11b685701b64a14fdda4ea",
    "testharness"
   ],
   "css/css-align/default-alignment/place-items-shorthand-003.html": [
    "f169ae9d27ef461fca3fae0729a7f3d41ddba6de",
    "testharness"
   ],
   "css/css-align/default-alignment/place-items-shorthand-004.html": [
-   "d4b6346f68b085a297ba5b15a5803258cbf661da",
+   "51b0eff81deca9f5e056f5db1d49f3e9be80435b",
    "testharness"
   ],
   "css/css-align/default-alignment/place-items-shorthand-005.html": [
    "638f5cbcc320477d495b9b0a752e6aaa048fee5e",
    "testharness"
   ],
   "css/css-align/default-alignment/place-items-shorthand-006.html": [
    "b7106d0ee863673c0d9a6160d035706edb3c67a8",
--- a/testing/web-platform/tests/css/css-align/content-distribution/place-content-shorthand-004.html
+++ b/testing/web-platform/tests/css/css-align/content-distribution/place-content-shorthand-004.html
@@ -43,11 +43,17 @@
     test(function() {
         checkInvalidValues("auto")
         checkInvalidValues("auto right")
         checkInvalidValues("auto auto")
         checkInvalidValues("start auto")
     }, "Verify 'auto' values are invalid");
 
     test(function() {
+        checkInvalidValues("self-start")
+        checkInvalidValues("center self-end")
+        checkInvalidValues("self-end start")
+    }, "Verify self-position values are invalid");
+
+    test(function() {
         checkInvalidValues("")
     }, "Verify empty declaration is invalid");
 </script>
--- a/testing/web-platform/tests/css/css-align/default-alignment/parse-justify-items-002.html
+++ b/testing/web-platform/tests/css/css-align/default-alignment/parse-justify-items-002.html
@@ -14,44 +14,44 @@
 container = document.createElement("div");
 element = document.createElement("div");
 container.appendChild(element);
 document.body.appendChild(container);
 
 test(function() {
     element = document.createElement("div");
     document.body.appendChild(element);
-    checkValues(element, "justifyItems", "justify-items", "", "legacy");
+    checkValues(element, "justifyItems", "justify-items", "", "normal");
 }, "Test 'initial' value when nothing is specified");
 
 test(function() {
     container.style.display = "";
-    checkInitialValues(element, "justifyItems", "justify-items", "center", "legacy");
+    checkInitialValues(element, "justifyItems", "justify-items", "center", "normal");
 }, "Test justify-items: 'initial'");
 
 test(function() {
     container.style.display = "grid";
-    checkInitialValues(element, "justifyItems", "justify-items", "safe start", "legacy");
+    checkInitialValues(element, "justifyItems", "justify-items", "safe start", "normal");
 }, "Test grid items justify-items: 'initial'");
 
 test(function() {
     container.style.display = "flex";
-    checkInitialValues(element, "justifyItems", "justify-items", "unsafe end", "legacy");
+    checkInitialValues(element, "justifyItems", "justify-items", "unsafe end", "normal");
 }, "Test flex items justify-items: 'initial'");
 
 test(function() {
     container.style.display = "";
     element.style.position = "absolute";
-    checkInitialValues(element, "justifyItems", "justify-items", "start", "legacy");
+    checkInitialValues(element, "justifyItems", "justify-items", "start", "normal");
 }, "Test absolute positioned elements justify-items: 'initial'");
 
 test(function() {
     container.style.display = "grid";
     element.style.position = "absolute";
-    checkInitialValues(element, "justifyItems", "justify-items", "end", "legacy");
+    checkInitialValues(element, "justifyItems", "justify-items", "end", "normal");
 }, "Test absolute positioned grid items justify-items: 'initial'");
 
 test(function() {
     container.style.display = "flex";
     element.style.position = "absolute";
-    checkInitialValues(element, "justifyItems", "justify-items", "end", "legacy");
+    checkInitialValues(element, "justifyItems", "justify-items", "end", "normal");
 }, "Test absolute positioned flex items justify-items: 'initial'");
 </script>
--- a/testing/web-platform/tests/css/css-align/default-alignment/place-items-shorthand-004.html
+++ b/testing/web-platform/tests/css/css-align/default-alignment/place-items-shorthand-004.html
@@ -32,14 +32,25 @@
         checkInvalidValues("10px left")
         checkInvalidValues("right 10%")
     }, "Verify numeric values are invalid");
 
     test(function() {
        checkInvalidValues("auto")
        checkInvalidValues("auto right")
        checkInvalidValues("auto auto")
-    }, "Verify 'auto' value is invalid as first longhand value.");
+       checkInvalidValues("center auto")
+    }, "Verify 'auto' value is invalid.");
+
+    test(function() {
+       checkInvalidValues("legacy")
+       checkInvalidValues("legacy start")
+       checkInvalidValues("end legacy")
+       checkInvalidValues("legacy left")
+       checkInvalidValues("center legacy")
+       checkInvalidValues("start legacy center")
+    }, "Verify 'legacy' value is invalid.");
+
 
     test(function() {
         checkInvalidValues("")
     }, "Verify empty declaration is invalid");
 </script>