Bug 1500070 - Avoid using about:debugging in generic about: page tests. r=jdescottes
authorAlexandre Poirot <poirot.alex@gmail.com>
Thu, 18 Oct 2018 13:40:48 +0000
changeset 500608 33e352068e35a538ff380ef30749e53946c5bdd3
parent 500607 fbb784c460e5fdc034e1e734fe5d5cfcd3c18c33
child 500609 14a6f6ecebc25ee188d852a4b12ed3befba3580a
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdescottes
bugs1500070
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1500070 - Avoid using about:debugging in generic about: page tests. r=jdescottes Opening about:debugging may lead to pending listAddons requests. Tests that open about:debugging should be careful to wait for the end of these requests, which this test doesn't do. MozReview-Commit-ID: 6YyfdW78kOS Depends on D8828 Differential Revision: https://phabricator.services.mozilla.com/D8867
browser/components/contextualidentity/test/browser/browser_aboutURLs.js
devtools/client/shared/test/browser_link.js
--- a/browser/components/contextualidentity/test/browser/browser_aboutURLs.js
+++ b/browser/components/contextualidentity/test/browser/browser_aboutURLs.js
@@ -11,16 +11,18 @@ add_task(async function() {
   let skipURLs = [
     // about:credits will initiate network request.
     "credits",
     // about:telemetry will fetch Telemetry asynchronously and takes longer,
     // so we skip this for now.
     "telemetry",
     // about:downloads causes a shutdown leak with stylo-chrome. bug 1419943.
     "downloads",
+    // about:debugging requires specific wait code for internal pending RDP requests.
+    "debugging",
   ];
 
   for (let cid in Cc) {
     let result = cid.match(/@mozilla.org\/network\/protocol\/about;1\?what\=(.*)$/);
     if (!result) {
       continue;
     }
 
--- a/devtools/client/shared/test/browser_link.js
+++ b/devtools/client/shared/test/browser_link.js
@@ -16,18 +16,18 @@ add_task(async function() {
   // Open a link to a page that will not trigger any request.
   info("Open web link to example.com test page");
   openDocLink(TEST_URI);
   await BrowserTestUtils.browserLoaded(gBrowser.selectedBrowser);
 
   is(gBrowser.selectedBrowser.currentURI.spec, TEST_URI,
     "openDocLink opened a tab with the expected url");
 
-  info("Open trusted link to about:debugging");
-  openTrustedLink("about:debugging");
+  info("Open trusted link to about:config");
+  openTrustedLink("about:config");
   await BrowserTestUtils.browserLoaded(gBrowser.selectedBrowser);
 
-  is(gBrowser.selectedBrowser.currentURI.spec, "about:debugging",
+  is(gBrowser.selectedBrowser.currentURI.spec, "about:config",
     "openTrustedLink opened a tab with the expected url");
 
   await removeTab(gBrowser.selectedTab);
   await removeTab(gBrowser.selectedTab);
 });