Bug 1511889 - Update clang-plugin LoadLibraryUsageChecker to use getBeginLoc. r=froydnj
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Thu, 06 Dec 2018 16:34:13 +0000
changeset 508751 335e8f4298ce517967691df1468bdbae7f62c287
parent 508750 f1b8313f08cf764ef27295456c9bf0661bd9db80
child 508752 3981db16d97257b88df7c9a940541444395f72c5
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1511889
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1511889 - Update clang-plugin LoadLibraryUsageChecker to use getBeginLoc. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D13726
build/clang-plugin/LoadLibraryUsageChecker.cpp
--- a/build/clang-plugin/LoadLibraryUsageChecker.cpp
+++ b/build/clang-plugin/LoadLibraryUsageChecker.cpp
@@ -21,14 +21,14 @@ void LoadLibraryUsageChecker::registerMa
           .bind("funcCall"),
       this);
 }
 
 void LoadLibraryUsageChecker::check(const MatchFinder::MatchResult &Result) {
   const CallExpr *FuncCall = Result.Nodes.getNodeAs<CallExpr>("funcCall");
 
   if (FuncCall) {
-    diag(FuncCall->getLocStart(),
+    diag(FuncCall->getBeginLoc(),
          "Usage of ASCII file functions (such as %0) is forbidden.",
          DiagnosticIDs::Error)
         << FuncCall->getDirectCallee()->getName();
   }
 }