Bug 1456235 [wpt PR 10586] - Allow column-width:0., a=testonly
authorMorten Stenshorne <mstensho@chromium.org>
Sun, 29 Apr 2018 20:42:19 +0000
changeset 472382 30247a52777d93ca3bbd11f4f9e9ab624f08bc2e
parent 472381 fd611937fde85767f9b5a8ffb903807bbdbcde48
child 472383 4921178aeb4ddd80a1465c0413e55b880f52778b
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1456235, 10586, 832085, 1023409, 552770
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1456235 [wpt PR 10586] - Allow column-width:0., a=testonly Automatic update from web-platform-testsAllow column-width:0. The spec recently changed from disallowing this to allowing it. Removed a test that expected it to be disallowed, and wrote new tests for the new expected behavior. Bug: 832085 Change-Id: Id6fa0a311fe3f50414c68658d807b99e92acc226 Reviewed-on: https://chromium-review.googlesource.com/1023409 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#552770} -- wpt-commits: 3a2abb9733a257061505ee7b410c393cea194ee2 wpt-pr: 10586
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/css-multicol/zero-column-width-computed-style.html
testing/web-platform/tests/css/css-multicol/zero-column-width-layout.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -121866,16 +121866,28 @@
       [
        "/css/css-multicol/multicol-zero-height-001-ref.xht",
        "=="
       ]
      ],
      {}
     ]
    ],
+   "css/css-multicol/zero-column-width-layout.html": [
+    [
+     "/css/css-multicol/zero-column-width-layout.html",
+     [
+      [
+       "/css/reference/ref-filled-green-100px-square-only.html",
+       "=="
+      ]
+     ],
+     {}
+    ]
+   ],
    "css/css-namespaces/prefix-001.xml": [
     [
      "/css/css-namespaces/prefix-001.xml",
      [
       [
        "/css/css-namespaces/reftest/ref-lime-1.xml",
        "=="
       ]
@@ -316011,16 +316023,22 @@
     ]
    ],
    "css/css-multicol/multicol-gap-percentage-001.html": [
     [
      "/css/css-multicol/multicol-gap-percentage-001.html",
      {}
     ]
    ],
+   "css/css-multicol/zero-column-width-computed-style.html": [
+    [
+     "/css/css-multicol/zero-column-width-computed-style.html",
+     {}
+    ]
+   ],
    "css/css-overflow/logical-overflow-001.html": [
     [
      "/css/css-overflow/logical-overflow-001.html",
      {}
     ]
    ],
    "css/css-overflow/overflow-shorthand-001.html": [
     [
@@ -508668,16 +508686,24 @@
   "css/css-multicol/support/test-tl.png": [
    "956e5156fd8c0e75b1c0f3b8b3b900b653663f74",
    "support"
   ],
   "css/css-multicol/support/test-tr.png": [
    "078e1dd6dd61d36cec239ed75d02051f61fe60a5",
    "support"
   ],
+  "css/css-multicol/zero-column-width-computed-style.html": [
+   "4128e1f5451a0e68d9a51eb23a7e8c3f409cbd80",
+   "testharness"
+  ],
+  "css/css-multicol/zero-column-width-layout.html": [
+   "15842618bf084ccc9aa5025ffd28ec978017f140",
+   "reftest"
+  ],
   "css/css-namespaces/OWNERS": [
    "2800c1b3fc3e3cc24ed318c374dd3ad0c312234a",
    "support"
   ],
   "css/css-namespaces/README": [
    "1e6602131246b9324691901a867aaf94d8e20b09",
    "support"
   ],
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-multicol/zero-column-width-computed-style.html
@@ -0,0 +1,14 @@
+<!DOCTYPE html>
+<title>column-width:0</title>
+<link rel="author" title="Morten Stenshorne" href="mstensho@chromium.org">
+<link rel="help" href="https://drafts.csswg.org/css-multicol/#cw" title="3.1. column-width">
+<div id="longhand" style="column-width:0;"></div>
+<div id="shorthand" style="columns:0;"></div>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script>
+test(() => {
+  assert_equals(getComputedStyle(longhand).columnWidth, "0px");
+  assert_equals(getComputedStyle(shorthand).columnWidth, "0px");
+}, "column-width:0 is a valid CSS declaration");
+</script>
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-multicol/zero-column-width-layout.html
@@ -0,0 +1,13 @@
+<!DOCTYPE html>
+<title>column-width:0</title>
+<meta name="assert" content="column-width:0 is valid as specified and computed value, but its used value may never be less than 1px">
+<link rel="author" title="Morten Stenshorne" href="mstensho@chromium.org">
+<link rel="help" href="https://drafts.csswg.org/css-multicol/#cw" title="3.1. column-width">
+<link rel="match" href="../reference/ref-filled-green-100px-square-only.html">
+<p>Test passes if there is a filled green square.</p>
+<div style="float:left; width:50px; height:100px; column-width:0; column-gap:0;">
+  <div style="height:5000px; background:green;"></div>
+</div>
+<div style="float:left; width:50px; height:100px; columns:0; column-gap:0;">
+  <div style="height:5000px; background:green;"></div>
+</div>