Backed out changeset 9a7b90cf8a63 (bug 1361618) for frequently failing accessible/tests/browser/states/browser_test_link.js (bug 1385498). r=backout a=backout
authorSebastian Hengst <archaeopteryx@coole-files.de>
Sat, 29 Jul 2017 11:42:39 +0200
changeset 422852 2fba314d7de77ad8ab693a2ea0112c0cda5dd564
parent 422851 ec666e910442ae55686160c1bd0c93b00a08dead
child 422924 cdb98cea92adbf901b34bebcdecb6f5908f2eeac
child 423001 4b38ba06881ed27254c46dc273663441837edf12
push id1517
push userjlorenzo@mozilla.com
push dateThu, 14 Sep 2017 16:50:54 +0000
treeherdermozilla-release@3b41fd564418 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout, backout
bugs1361618, 1385498
milestone56.0a1
backs out9a7b90cf8a63ac8bbee85c0b2333902dd74cc5fe
first release with
nightly linux32
2fba314d7de7 / 56.0a1 / 20170729100254 / files
nightly linux64
2fba314d7de7 / 56.0a1 / 20170729100254 / files
nightly mac
2fba314d7de7 / 56.0a1 / 20170729100254 / files
nightly win32
2fba314d7de7 / 56.0a1 / 20170729100254 / files
nightly win64
2fba314d7de7 / 56.0a1 / 20170729100254 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 9a7b90cf8a63 (bug 1361618) for frequently failing accessible/tests/browser/states/browser_test_link.js (bug 1385498). r=backout a=backout MozReview-Commit-ID: DK2CuaYBPbj
layout/base/GeckoRestyleManager.cpp
layout/base/nsCSSFrameConstructor.cpp
--- a/layout/base/GeckoRestyleManager.cpp
+++ b/layout/base/GeckoRestyleManager.cpp
@@ -1818,16 +1818,17 @@ ElementRestyler::Restyle(nsRestyleHint a
       // up the hint for one of the ancestors that we hit first, then
       // we'll fail to do the restyling we need to do.
       // Likewise, if we're restyling something with two nested frames,
       // and we post a restyle from the transition manager while
       // computing style for the outer frame (to be computed after the
       // descendants have been resolved), we don't want to consume it
       // for the inner frame.
       mContent->GetPrimaryFrame() == mFrame) {
+    mContent->OwnerDoc()->FlushPendingLinkUpdates();
     nsAutoPtr<RestyleTracker::RestyleData> restyleData;
     if (mRestyleTracker.GetRestyleData(mContent->AsElement(), restyleData)) {
       nsChangeHint changeToAppend =
         NS_RemoveSubsumedHints(restyleData->mChangeHint,
                                mHintsHandledByAncestors);
       // See the comment in CaptureChange about why we use NS_IsHintSubset here.
       if (!NS_IsHintSubset(changeToAppend, mHintsHandledBySelf)) {
         mHintsHandledBySelf |= changeToAppend;
--- a/layout/base/nsCSSFrameConstructor.cpp
+++ b/layout/base/nsCSSFrameConstructor.cpp
@@ -5151,16 +5151,17 @@ nsCSSFrameConstructor::ResolveStyleConte
 
 already_AddRefed<nsStyleContext>
 nsCSSFrameConstructor::ResolveStyleContext(nsStyleContext* aParentStyleContext,
                                            nsIContent* aContent,
                                            nsFrameConstructorState* aState,
                                            Element* aOriginatingElementOrNull)
 {
   StyleSetHandle styleSet = mPresShell->StyleSet();
+  aContent->OwnerDoc()->FlushPendingLinkUpdates();
 
   RefPtr<nsStyleContext> result;
   if (aContent->IsElement()) {
     auto pseudoType = aContent->AsElement()->GetPseudoElementType();
     if (pseudoType == CSSPseudoElementType::NotPseudo) {
       MOZ_ASSERT(!aOriginatingElementOrNull);
       if (aState) {
         result = styleSet->ResolveStyleFor(aContent->AsElement(),