Bug 1430622: Don't allow fallback alignment in place-content shorthand. r=xidorn,mats
authorEmilio Cobos Álvarez <emilio@crisal.io>
Mon, 15 Jan 2018 22:34:34 +0100
changeset 453792 2ea467872d7fcd3dbb31fcf881e4147b6dd6bebe
parent 453791 1d8507d97baacd9f3a042b6a08ae2db9daca767e
child 453800 929bf53b16fb1e01acdcdfcb740ee4ce73eb2fda
push id1648
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 12:45:47 +0000
treeherdermozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersxidorn, mats
bugs1430622
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1430622: Don't allow fallback alignment in place-content shorthand. r=xidorn,mats MozReview-Commit-ID: sALBFJeqvr
testing/web-platform/meta/MANIFEST.json
testing/web-platform/meta/css/css-align/content-distribution/place-content-shorthand-002.html.ini
testing/web-platform/meta/css/css-align/content-distribution/place-content-shorthand-004.html.ini
testing/web-platform/meta/css/css-align/content-distribution/place-content-shorthand-006.html.ini
testing/web-platform/tests/css/css-align/content-distribution/place-content-shorthand-007-ref.html
testing/web-platform/tests/css/css-align/content-distribution/place-content-shorthand-007.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -97750,16 +97750,28 @@
       [
        "/css/compositing/svg/reference/mix-blend-mode-svg-rectangle-ref.html",
        "=="
       ]
      ],
      {}
     ]
    ],
+   "css/css-align/content-distribution/place-content-shorthand-007.html": [
+    [
+     "/css/css-align/content-distribution/place-content-shorthand-007.html",
+     [
+      [
+       "/css/css-align/content-distribution/place-content-shorthand-007-ref.html",
+       "=="
+      ]
+     ],
+     {}
+    ]
+   ],
    "css/css-align/distribution-values/space-evenly-001.html": [
     [
      "/css/css-align/distribution-values/space-evenly-001.html",
      [
       [
        "/css/reference/ref-filled-green-100px-square.xht",
        "=="
       ]
@@ -231571,16 +231583,21 @@
      {}
     ]
    ],
    "css/compositing/text-with-svg-background-ref.html": [
     [
      {}
     ]
    ],
+   "css/css-align/content-distribution/place-content-shorthand-007-ref.html": [
+    [
+     {}
+    ]
+   ],
    "css/css-align/reference/ttwf-reftest-alignContent-ref.html": [
     [
      {}
     ]
    ],
    "css/css-align/resources/alignment-parsing-utils.js": [
     [
      {}
@@ -468878,16 +468895,24 @@
   "css/css-align/content-distribution/place-content-shorthand-005.html": [
    "6b3d7b9ae7d5b28510385cccaaade09268409cab",
    "testharness"
   ],
   "css/css-align/content-distribution/place-content-shorthand-006.html": [
    "016c2ff7902fc01d8368645b7177e3932aa64d42",
    "testharness"
   ],
+  "css/css-align/content-distribution/place-content-shorthand-007-ref.html": [
+   "6008fc2ca235c4b4c171ace405fd312647be3313",
+   "support"
+  ],
+  "css/css-align/content-distribution/place-content-shorthand-007.html": [
+   "5268627f55928b969e022a626961958ac8f92e05",
+   "reftest"
+  ],
   "css/css-align/default-alignment/justify-items-legacy-001.html": [
    "bcf17f709a9b87ef728262b658d1dfa65afc93bb",
    "testharness"
   ],
   "css/css-align/default-alignment/place-items-shorthand-001.html": [
    "cc69bbbee852e6cd203d3f39dac2a1e05a428361",
    "testharness"
   ],
@@ -529267,17 +529292,17 @@
    "228d4a90d57dc942692becc6f126ec9130b3a4e0",
    "testharness"
   ],
   "custom-elements/parser/parser-fallsback-to-unknown-element.html": [
    "2fbbd742bfdc3ab63c5d5f01160830451fe620d2",
    "testharness"
   ],
   "custom-elements/parser/parser-sets-attributes-and-children.html": [
-   "9157427f1c1e3d30d8a470ce7bd756dbf3a0cdfe",
+   "8049449173e4082b2f4ccadfe552abadadc0834a",
    "testharness"
   ],
   "custom-elements/parser/parser-uses-constructed-element.html": [
    "ed5476ab5b9a8d23ab7d84665c5d3224bb53dd18",
    "testharness"
   ],
   "custom-elements/parser/parser-uses-registry-of-owner-document.html": [
    "a62669ffcc75d54df38b65e33463566238c8644c",
@@ -582591,37 +582616,37 @@
    "b11caf0a1766818a168a7f91b01ccd6ae9a7e4f0",
    "testharness"
   ],
   "web-animations/interfaces/DocumentTimeline/idlharness.html": [
    "72cb7900f86611e9c2a1b0f4acd0f634555310b9",
    "testharness"
   ],
   "web-animations/interfaces/KeyframeEffect/composite.html": [
-   "7dd18327d8da81914adaf443086891ba3646d882",
+   "12fc2e8e7bcfb1eab6e162b68731ff6fcb767438",
    "testharness"
   ],
   "web-animations/interfaces/KeyframeEffect/constructor.html": [
-   "4a80ea073da0a9c62dcb9587676445a2fba234e1",
+   "2f6449cbf2b47ae457efb23fb52b8fd1709837ac",
    "testharness"
   ],
   "web-animations/interfaces/KeyframeEffect/copy-constructor.html": [
    "6ef462ddc696269f132d596188ffd5e8da1e1164",
    "testharness"
   ],
   "web-animations/interfaces/KeyframeEffect/idlharness.html": [
    "f05c9bd1cdee77ff6be143b0eb4f982c7218908b",
    "testharness"
   ],
   "web-animations/interfaces/KeyframeEffect/iterationComposite.html": [
    "65cd746596a6770d1101b030769712be433bf6f3",
    "testharness"
   ],
   "web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html": [
-   "165b651cea12ab9e0825f4335e7f697ce1fc6247",
+   "f54c7c0da5728f88f37a067761af7ad815fea005",
    "testharness"
   ],
   "web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002.html": [
    "e9237e244034845f6f902f8149a0e66e5b6164f2",
    "testharness"
   ],
   "web-animations/interfaces/KeyframeEffect/setKeyframes.html": [
    "a346e0e004010a6f51e06ffd30d0b6eddd45421d",
@@ -582635,17 +582660,17 @@
    "77f747cef865fd5eba6ea621881706f801c812c0",
    "support"
   ],
   "web-animations/resources/effect-tests.js": [
    "2eb26f4cb0e65282b8e82014ac8ebe87a4209c6a",
    "support"
   ],
   "web-animations/resources/keyframe-tests.js": [
-   "52ffc50c4ebf0326db8f4e1d0cc1234f6c860dc2",
+   "b31029042fdfa77ba8bf0e9370f63a423fbe0da9",
    "support"
   ],
   "web-animations/resources/keyframe-utils.js": [
    "08da0c81847809328bda0d6e0581711f7838916e",
    "support"
   ],
   "web-animations/resources/xhr-doc.py": [
    "de68c45fc1d38a49946f9046f34031e9278a1531",
--- a/testing/web-platform/meta/css/css-align/content-distribution/place-content-shorthand-002.html.ini
+++ b/testing/web-platform/meta/css/css-align/content-distribution/place-content-shorthand-002.html.ini
@@ -81,232 +81,8 @@
     expected: FAIL
 
   [Checking place-content: first baseline last baseline]
     expected: FAIL
 
   [Checking place-content: last baseline first baseline]
     expected: FAIL
 
-  [Checking place-content: start stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: start space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: start space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: start space-evenly]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: end stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: end space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: end space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: end space-evenly]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: left stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: left space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: left space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: left space-evenly]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: right stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: right space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: right space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: right space-evenly]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: center stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: center space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: center space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: center space-evenly]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-start stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-start space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-start space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-start space-evenly]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-end stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-end space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-end space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-end space-evenly]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: stretch start]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: stretch end]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: stretch left]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: stretch right]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: stretch center]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: stretch flex-start]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: stretch flex-end]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-around start]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-around end]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-around left]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-around right]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-around center]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-around flex-start]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-around flex-end]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-between start]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-between end]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-between left]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-between right]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-between center]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-between flex-start]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-between flex-end]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-evenly start]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-evenly end]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-evenly left]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-evenly right]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-evenly center]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-evenly flex-start]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: space-evenly flex-end]
-    expected:
-      if stylo: FAIL
-
deleted file mode 100644
--- a/testing/web-platform/meta/css/css-align/content-distribution/place-content-shorthand-004.html.ini
+++ /dev/null
@@ -1,5 +0,0 @@
-[place-content-shorthand-004.html]
-  [Verify fallback values are invalid]
-    expected:
-      if stylo: FAIL
-
--- a/testing/web-platform/meta/css/css-align/content-distribution/place-content-shorthand-006.html.ini
+++ b/testing/web-platform/meta/css/css-align/content-distribution/place-content-shorthand-006.html.ini
@@ -84,120 +84,8 @@
     expected: FAIL
 
   [Checking place-content: first baseline last baseline]
     expected: FAIL
 
   [Checking place-content: last baseline first baseline]
     expected: FAIL
 
-  [Checking place-content: start stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: start space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: start space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: start space-evenly]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: end stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: end space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: end space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: end space-evenly]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: left stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: left space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: left space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: left space-evenly]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: right stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: right space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: right space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: right space-evenly]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: center stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: center space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: center space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: center space-evenly]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-start stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-start space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-start space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-start space-evenly]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-end stretch]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-end space-around]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-end space-between]
-    expected:
-      if stylo: FAIL
-
-  [Checking place-content: flex-end space-evenly]
-    expected:
-      if stylo: FAIL
-
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-align/content-distribution/place-content-shorthand-007-ref.html
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>CSS Test Reference</title>
+<link rel="author" title="Emilio Cobos Álvarez" href="mailto:emilio@crisal.io">
+<style>
+div {
+  width: 400px;
+  height: 400px;
+  background: blue;
+  position: relative;
+}
+span {
+  background: green;
+  width: 200px;
+  height: 200px;
+  position: absolute;
+  bottom: 0;
+  left: 100px;
+}
+</style>
+Should see a green square centered and at the bottom of the blue square.
+<div><span></span></div>
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-align/content-distribution/place-content-shorthand-007.html
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>CSS Box Alignment: place-content shorthand with fallback</title>
+<link rel="author" title="Emilio Cobos Álvarez" href="mailto:emilio@crisal.io">
+<link rel="help" href="https://drafts.csswg.org/css-align/#propdef-place-content">
+<link rel="help" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1430622">
+<link rel="match" href="place-content-shorthand-007-ref.html">
+<style>
+div {
+  display: grid;
+  grid: 200px / 200px;
+  width: 400px;
+  height: 400px;
+  background: blue;
+  place-content: end space-evenly;
+}
+span {
+  background: green;
+}
+</style>
+Should see a green square centered and at the bottom of the blue square.
+<div><span></span></div>