Bug 1452146 - flip av1 and rdd on for OSX and Win. r=drno
☠☠ backed out by c4a45f2bd139 ☠ ☠
authorMichael Froman <mfroman@mozilla.com>
Fri, 30 Nov 2018 00:46:17 +0000
changeset 508105 2e6cbbc4c53e3c0cc762b8c716d5e6370a11bd17
parent 508104 b81d44f829c9c9fcb3335fc7b0fa44f183f2b786
child 508106 12525933eb9e4b77aed03ef536aac18a36f81278
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdrno
bugs1452146
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1452146 - flip av1 and rdd on for OSX and Win. r=drno Differential Revision: https://phabricator.services.mozilla.com/D13482
modules/libpref/init/StaticPrefList.h
modules/libpref/init/all.js
--- a/modules/libpref/init/StaticPrefList.h
+++ b/modules/libpref/init/StaticPrefList.h
@@ -1098,21 +1098,27 @@ VARCACHE_PREF(
 #endif
 VARCACHE_PREF(
   "media.gpu-process-decoder",
    MediaGpuProcessDecoder,
   RelaxedAtomicBool, PREF_VALUE
 )
 #undef PREF_VALUE
 
+#if defined(XP_WIN) || defined(XP_MACOSX)
+# define PREF_VALUE true
+#else
+# define PREF_VALUE false
+#endif
 VARCACHE_PREF(
   "media.rdd-process.enabled",
    MediaRddProcessEnabled,
-  RelaxedAtomicBool, false
+  RelaxedAtomicBool, PREF_VALUE
 )
+#undef PREF_VALUE
 
 VARCACHE_PREF(
   "media.rdd-process.startup_timeout_ms",
    MediaRddProcessStartupTimeoutMs,
   RelaxedAtomicInt32, 5000
 )
 
 #ifdef ANDROID
@@ -1413,21 +1419,27 @@ VARCACHE_PREF(
 // WebM
 VARCACHE_PREF(
   "media.webm.enabled",
    MediaWebMEnabled,
   RelaxedAtomicBool, true
 )
 
 // AV1
+#if defined(XP_WIN) || defined(XP_MACOSX)
+# define PREF_VALUE true
+#else
+# define PREF_VALUE false
+#endif
 VARCACHE_PREF(
   "media.av1.enabled",
    MediaAv1Enabled,
-  RelaxedAtomicBool, false
+  RelaxedAtomicBool, PREF_VALUE
 )
+#undef PREF_VALUE
 VARCACHE_PREF(
   "media.av1.use-dav1d",
    MediaAv1UseDav1d,
   RelaxedAtomicBool, false
 )
 
 VARCACHE_PREF(
   "media.flac.enabled",
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -637,17 +637,21 @@ pref("media.cubeb.sandbox", true);
 pref("media.audioipc.pool_size", 2);
 // 64 * 4 kB stack per pool thread.
 pref("media.audioipc.stack_size", 262144);
 #else
 pref("media.cubeb.sandbox", false);
 #endif
 
 #ifdef MOZ_AV1
+#if defined(XP_MACOSX) || defined(XP_WIN)
+pref("media.av1.enabled", true);
+#else
 pref("media.av1.enabled", false);
+#endif
 // Use libdav1d instead of libaom
 pref("media.av1.use-dav1d", false);
 #endif
 
 pref("media.webaudio.audiocontextoptions-samplerate.enabled", true);
 
 // setSinkId expected to be unconditionally enabled in 63. Till then the
 // implementation will remain hidden behind this pref (Bug 1152401, Bug 934425).