servo: Merge #18979 - Windows Build: Install Visual Studio at default location (from sgift:patch-1); r=mbrubeck
authorSebastian Gift <sebastian.gift@gmail.com>
Thu, 26 Oct 2017 12:37:31 -0500
changeset 441742 2d5271ee816167f0a23ae7bf41bd5dff4117574d
parent 441741 6d2368c95edb057ecd1043e6b183347127159a1e
child 441743 138e83fdc400d9ace33cbda7113a8a3342a0b256
push id1618
push userCallek@gmail.com
push dateThu, 11 Jan 2018 17:45:48 +0000
treeherdermozilla-release@882ca853e05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmbrubeck
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
servo: Merge #18979 - Windows Build: Install Visual Studio at default location (from sgift:patch-1); r=mbrubeck Visual Studio 2017 has to be installed at the default location or mach.bat will show an error that Visual Studio 2017 is not installed when trying to build servo. [X] These changes do not require tests because no code is changed, documentation only. Source-Repo: https://github.com/servo/servo Source-Revision: fd4843a40ef7c000bbd747208fcf61267dbf157f
servo/README.md
--- a/servo/README.md
+++ b/servo/README.md
@@ -106,17 +106,17 @@ 2. Install virtualenv.
 pip install virtualenv
 ```
  If this does not work, you may need to reboot for the changed PATH settings (by the python installer) to take effect.
 
 3. Install Git for Windows (https://git-scm.com/download/win). DO allow it to add git.exe to the PATH (default
 settings for the installer are fine).
 
 4. Install Visual Studio Community 2017 (https://www.visualstudio.com/vs/community/). You MUST add "Visual C++" to the
-list of installed components. It is not on by default.
+list of installed components. It is not on by default. Visual Studio 2017 MUST installed to the default location or mach.bat will not find it.
 > If you encountered errors with the environment above, do the following for a workaround:
 > 1.  Download and install [Build Tools for Visual Studio 2017](https://www.visualstudio.com/thank-you-downloading-visual-studio/?sku=BuildTools&rel=15)
 > 2.  Install `python2.7 x86-x64` and `virtualenv`
 > 3.  Run `mach.bat build -d`. 
 
 >If you have troubles with `x64 type` prompt as `mach.bat` set by default:  
 > 1. you may need to choose and launch the type manually, such as `x86_x64 Cross Tools Command Prompt for VS 2017` in the Windows menu.)
 > 2. `cd to/the/path/servo`