Bug 1456860 [wpt PR 10638] - Fix test for Event.returnValue, a=testonly
authorZirro <code@zirro.se>
Tue, 01 May 2018 14:36:38 +0000
changeset 472649 2afd61b0519dfa4509f8483676e819217609095d
parent 472648 b974f399050e615673c4ff281223bbafd235ea9d
child 472650 77eaba20ef9662629e8563500da371cb7fa247de
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1456860, 10638
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1456860 [wpt PR 10638] - Fix test for Event.returnValue, a=testonly Automatic update from web-platform-testsDOM: fix test for Event.returnValue The test requires the event to be cancelable. See https://github.com/jsdom/jsdom/pull/2197. -- wpt-commits: 6c62c5b8d7e7f80b3a3a84c7d0296c06d90c03f7 wpt-pr: 10638
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/dom/events/Event-returnValue.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -552681,17 +552681,17 @@
    "2fa55ddfd906a7cbc5e3e23419b6bf7fd3ca9158",
    "testharness"
   ],
   "dom/events/Event-propagation.html": [
    "43ec5c9e681c20864a932635889e05969fd7b8f1",
    "testharness"
   ],
   "dom/events/Event-returnValue.html": [
-   "93aed4161f60e8f9a2348dd29659f93ac7bd087f",
+   "919ec2325c6f210e079ee78532ecb5b3138b68cc",
    "testharness"
   ],
   "dom/events/Event-subclasses-constructors.html": [
    "52382c89b67be3c3fbb8bccccb6f75a4aaa7975b",
    "testharness"
   ],
   "dom/events/Event-timestamp-high-resolution.html": [
    "b850d06415afbd533b822efaa59efaee2375065d",
--- a/testing/web-platform/tests/dom/events/Event-returnValue.html
+++ b/testing/web-platform/tests/dom/events/Event-returnValue.html
@@ -48,17 +48,17 @@ test(function() {
   var ev = document.createEvent("Event");
   ev.returnValue = false;
   ev.initEvent("foo", true, true);
   assert_true(ev.bubbles, "bubbles");
   assert_true(ev.cancelable, "cancelable");
   assert_true(ev.returnValue, "returnValue");
 }, "initEvent should unset returnValue.");
 test(function() {
-  var ev = new Event("foo");
+  var ev = new Event("foo", {"cancelable": true});
   ev.preventDefault();
   ev.returnValue = true;// no-op
   assert_true(ev.defaultPrevented);
   assert_false(ev.returnValue);
 }, "returnValue=true should have no effect once the canceled flag was set.");
   </script>
 </body>
 </html>