Bug 1183037: Ensure that autocomplete popups can be displayed again after being dismissed the first time. r=mconley, a=gchang
authorStephen A Pohl <spohl.mozilla.bugs@gmail.com>
Mon, 24 Oct 2016 11:46:16 -0400
changeset 358564 29a2722ad4617e1644289a37e1920f96b3fc35ef
parent 358563 6c48afd1ecc1f9fc17507b6ab2d60ce5941e15bf
child 358565 70025dbda133b182ebdb88e7f2baa62d914648ce
push id1324
push usermtabara@mozilla.com
push dateMon, 16 Jan 2017 13:07:44 +0000
treeherdermozilla-release@a01c49833940 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley, gchang
bugs1183037
milestone51.0a2
Bug 1183037: Ensure that autocomplete popups can be displayed again after being dismissed the first time. r=mconley, a=gchang
toolkit/components/satchel/nsFormFillController.cpp
--- a/toolkit/components/satchel/nsFormFillController.cpp
+++ b/toolkit/components/satchel/nsFormFillController.cpp
@@ -1051,18 +1051,19 @@ nsFormFillController::MouseDown(nsIDOMEv
 
   int16_t button;
   mouseEvent->GetButton(&button);
   if (button != 0)
     return NS_OK;
 
   bool isOpen = false;
   GetPopupOpen(&isOpen);
-  if (isOpen)
-    return NS_OK;
+  if (isOpen) {
+    return SetPopupOpen(false);
+  }
 
   nsCOMPtr<nsIAutoCompleteInput> input;
   mController->GetInput(getter_AddRefs(input));
   if (!input)
     return NS_OK;
 
   nsAutoString value;
   input->GetTextValue(value);