Bug 1215455 - eslint array-bracket-spacing [r=Standard8]
authorEd Lee <edilee@mozilla.com>
Fri, 16 Oct 2015 01:11:48 -0700
changeset 304181 2788036d08a80b062f70832a0a75e37acccc182e
parent 304180 70d83aad0cc13333ab6ba541f897e6b05e21917a
child 304182 5f023c0c5fb33e4ac636d9c6d13892e377ef4e97
push id1001
push userraliiev@mozilla.com
push dateMon, 18 Jan 2016 19:06:03 +0000
treeherdermozilla-release@8b89261f3ac4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersStandard8
bugs1215455
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1215455 - eslint array-bracket-spacing [r=Standard8]
browser/components/loop/.eslintrc
browser/components/loop/content/js/roomViews.js
browser/components/loop/content/js/roomViews.jsx
browser/components/loop/test/mochitest/browser_LoopRooms_channel.js
browser/components/loop/test/mochitest/browser_toolbarbutton.js
--- a/browser/components/loop/.eslintrc
+++ b/browser/components/loop/.eslintrc
@@ -29,16 +29,17 @@
   },
   "rules": {
     // turn off all kinds of stuff that we actually do want, because
     // right now, we're bootstrapping the linting infrastructure.  We'll
     // want to audit these rules, and start turning them on and fixing the
     // problems they find, one at a time.
 
     // Eslint built-in rules are documented at <http://eslint.org/docs/rules/>
+    "array-bracket-spacing": [2, "never"],
     "block-spacing": [2, "always"],
     "callback-return": 0,         // TBD
     "camelcase": 0,               // TODO: set to 2
     "comma-spacing": 2,
     "comma-style": 2,
     "computed-property-spacing": [2, "never"],
     "consistent-return": 0,       // TODO: set to 2
     "curly": [2, "all"],
--- a/browser/components/loop/content/js/roomViews.js
+++ b/browser/components/loop/content/js/roomViews.js
@@ -112,17 +112,17 @@ loop.roomViews = (function(mozL10n) {
       );
     }
   });
 
   /**
    * Something went wrong view. Displayed when there's a big problem.
    */
   var RoomFailureView = React.createClass({displayName: "RoomFailureView",
-    mixins: [ sharedMixins.AudioMixin ],
+    mixins: [sharedMixins.AudioMixin],
 
     propTypes: {
       dispatcher: React.PropTypes.instanceOf(loop.Dispatcher).isRequired,
       failureReason: React.PropTypes.string,
       mozLoop: React.PropTypes.object.isRequired
     },
 
     componentDidMount: function() {
--- a/browser/components/loop/content/js/roomViews.jsx
+++ b/browser/components/loop/content/js/roomViews.jsx
@@ -112,17 +112,17 @@ loop.roomViews = (function(mozL10n) {
       );
     }
   });
 
   /**
    * Something went wrong view. Displayed when there's a big problem.
    */
   var RoomFailureView = React.createClass({
-    mixins: [ sharedMixins.AudioMixin ],
+    mixins: [sharedMixins.AudioMixin],
 
     propTypes: {
       dispatcher: React.PropTypes.instanceOf(loop.Dispatcher).isRequired,
       failureReason: React.PropTypes.string,
       mozLoop: React.PropTypes.object.isRequired
     },
 
     componentDidMount: function() {
--- a/browser/components/loop/test/mochitest/browser_LoopRooms_channel.js
+++ b/browser/components/loop/test/mochitest/browser_LoopRooms_channel.js
@@ -16,17 +16,17 @@ const TEST_URI =
 const TEST_URI_GOOD = Services.io.newURI("https://" + TEST_URI, null, null);
 const TEST_URI_BAD = Services.io.newURI("http://" + TEST_URI, null, null);
 
 const ROOM_TOKEN = "fake1234";
 const LINKCLICKER_URL_PREFNAME = "loop.linkClicker.url";
 
 var openChatOrig = Chat.open;
 
-var fakeRoomList = new Map([[ ROOM_TOKEN, { roomToken: ROOM_TOKEN } ]]);
+var fakeRoomList = new Map([[ROOM_TOKEN, { roomToken: ROOM_TOKEN }]]);
 
 function BackChannel(uri) {
   this.channel = new WebChannel("test-loop-link-clicker-backchannel", uri);
 
   this.channel.listen((id, data) => {
     if (this.pendingResolve) {
       let resolve = this.pendingResolve;
       this.pendingResolve = null;
--- a/browser/components/loop/test/mochitest/browser_toolbarbutton.js
+++ b/browser/components/loop/test/mochitest/browser_toolbarbutton.js
@@ -122,17 +122,17 @@ add_task(function* test_active() {
   MozLoopServiceInternal.notifyStatusChanged();
   Assert.strictEqual(LoopUI.toolbarButton.node.getAttribute("state"), "", "Check button is in default state");
   Assert.strictEqual(LoopUI.toolbarButton.node.getAttribute("tooltiptext"), "Start a conversation", "Check button has default tooltiptext");
 });
 
 add_task(function* test_room_participants() {
   Assert.strictEqual(LoopUI.toolbarButton.node.getAttribute("state"), "", "Check button is in default state");
   Assert.strictEqual(LoopUI.toolbarButton.node.getAttribute("tooltiptext"), "Start a conversation", "Check button has default tooltiptext");
-  let roomsCache = new Map([[ "test_room", {participants: [{displayName: "hugh", id: "008", owner: true}]} ]]);
+  let roomsCache = new Map([["test_room", {participants: [{displayName: "hugh", id: "008", owner: true}]}]]);
   LoopRooms._setRoomsCache(roomsCache);
   MozLoopServiceInternal.notifyStatusChanged();
   // Since we're changing the rooms map directly, we're expecting it to be a synchronous operation.
   // But Promises have the inherent property of then-ables being async so even though the operation returns immediately,
   // because the cache is hit, the promise won't be resolved until after the next tick.
   // And that's what the line below does, waits until the next tick
   yield new Promise(resolve => executeSoon(resolve));
   Assert.strictEqual(LoopUI.toolbarButton.node.getAttribute("state"), "active", "Check button is in active state");