Bug 932335 - Pre 3: Make getPreferredSizeFaviconForPage private r=me
authorAndrzej Hunt <ahunt@mozilla.com>
Mon, 23 May 2016 13:29:15 -0700
changeset 340674 228556a98ec92b6ca7782e1bd9f8c0dc70aae6a5
parent 340673 41b8ce50bc2726cf588680646bae48737f57cf67
child 340675 0a86d2aee5eb037767c6161b89a6816d64eda887
push id1183
push userraliiev@mozilla.com
push dateMon, 05 Sep 2016 20:01:49 +0000
treeherdermozilla-release@3148731bed45 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs932335
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 932335 - Pre 3: Make getPreferredSizeFaviconForPage private r=me We only use this in getPreferredIconForHomeScreenShortcut, we don't need to expose this elsewhere. It might be nice to move it directly into getPreferredIconForHomeScreenShortcut, but the separation allows for some more useful documentation. MozReview-Commit-ID: E92aLMgp2tl
mobile/android/base/java/org/mozilla/gecko/favicons/Favicons.java
--- a/mobile/android/base/java/org/mozilla/gecko/favicons/Favicons.java
+++ b/mobile/android/base/java/org/mozilla/gecko/favicons/Favicons.java
@@ -590,17 +590,17 @@ public class Favicons {
      *
      * The icon will be scaled to the preferred Android launcher icon size.
      *
      * Deduces the favicon URL from the browser database, guessing if necessary.
      *
      * @param url page URL to get a large favicon image for.
      * @param onFaviconLoadedListener listener to call back with the result.
      */
-    public static void getPreferredSizeFaviconForPage(Context context, String url, String iconURL, OnFaviconLoadedListener onFaviconLoadedListener) {
+    private static void getPreferredSizeFaviconForPage(Context context, String url, String iconURL, OnFaviconLoadedListener onFaviconLoadedListener) {
         int preferredSize = GeckoAppShell.getPreferredIconSize();
         loadUncachedFavicon(context, url, iconURL, LoadFaviconTask.FLAG_BYPASS_CACHE_WHEN_DOWNLOADING_ICONS, preferredSize, onFaviconLoadedListener);
     }
 
     /**
      * Load the icon that is the most suitable for using as a home screen shortcut.
      *
      * This method will try to load a 'touch icon' first. If not available it will fallback to use