Bug 1563353 - Disable two PromptDelegate tests for intermittent failures. r=snorp
authorDylan Roeh <droeh@mozilla.com>
Fri, 05 Jul 2019 15:19:48 +0000
changeset 544351 2102472ba072ff130a232f6516e3c4417a40c8a4
parent 544350 fb193ef6ed3f768bd7fd16f6ee7d642d19c584a7
child 544352 95dbf20a4c0482af6b643a0993a4588cab3efdca
push id2131
push userffxbld-merge
push dateMon, 26 Aug 2019 18:30:20 +0000
treeherdermozilla-release@b19ffb3ca153 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssnorp
bugs1563353
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1563353 - Disable two PromptDelegate tests for intermittent failures. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D37071
mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/PromptDelegateTest.kt
--- a/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/PromptDelegateTest.kt
+++ b/mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/PromptDelegateTest.kt
@@ -102,16 +102,17 @@ class PromptDelegateTest : BaseSessionTe
                 return null
             }
         })
 
         sessionRule.session.loadTestPath(POPUP_HTML_PATH)
         sessionRule.session.waitForPageStop()
     }
 
+    @Ignore // TODO: Reenable when 1501574 is fixed.
     @Test fun alertTest() {
         sessionRule.session.evaluateJS("alert('Alert!');")
 
         sessionRule.waitUntilCalled(object : Callbacks.PromptDelegate {
             @AssertCalled(count = 1)
             override fun onAlert(session: GeckoSession, title: String?, msg: String?, callback: GeckoSession.PromptDelegate.AlertCallback) {
                 assertThat("Message should match", "Alert!", equalTo(msg))
             }
@@ -132,16 +133,17 @@ class PromptDelegateTest : BaseSessionTe
                     //TODO: Figure out some better testing here.
                 }
             })
         } finally {
             httpBin.stop()
         }
     }
 
+    @Ignore // TODO: Reenable when 1501574 is fixed.
     @Test fun buttonTest() {
         sessionRule.delegateDuringNextWait(object : Callbacks.PromptDelegate {
             @AssertCalled(count = 1)
             override fun onButtonPrompt(session: GeckoSession, title: String?, msg: String?, btnMsg: Array<out String>?, callback: GeckoSession.PromptDelegate.ButtonCallback) {
                 assertThat("Message should match", "Confirm?", equalTo(msg))
                 callback.confirm(GeckoSession.PromptDelegate.BUTTON_TYPE_POSITIVE)
             }
         })