Bug 1497259 - 2. Don't log auto-fill values; r=droeh
authorJim Chen <nchen@mozilla.com>
Wed, 10 Oct 2018 17:36:11 +0000
changeset 499040 20cd9ac747da9b457d594fb385f13ace7bffbff2
parent 499039 50b9d2e6ac5f0d14822601bcf403b8f80ce5e3d4
child 499041 0df87bbe161e757b7fee9a0213ef07a62bf77ae9
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdroeh
bugs1497259
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1497259 - 2. Don't log auto-fill values; r=droeh Auto-fill values can contain personal information and must not appear in the log. Differential Revision: https://phabricator.services.mozilla.com/D8051
mobile/android/geckoview/src/main/java/org/mozilla/geckoview/SessionAccessibility.java
mobile/android/geckoview/src/main/java/org/mozilla/geckoview/SessionTextInput.java
mobile/android/modules/geckoview/GeckoViewAutoFill.jsm
--- a/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/SessionAccessibility.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/SessionAccessibility.java
@@ -700,17 +700,17 @@ public class SessionAccessibility {
             if (bundle == null) {
                 return false;
             }
             rootId = currentId;
             currentId = bundle.getInt("parent", View.NO_ID);
         }
 
         if (DEBUG) {
-            Log.d(LOGTAG, "performAutoFill(" + id + ", " + value + ')');
+            Log.d(LOGTAG, "performAutoFill(" + id + ')');
         }
 
         final EventCallback callback = mAutoFillRoots.get(rootId);
         if (callback == null) {
             return false;
         }
 
         final GeckoBundle response = new GeckoBundle(1);
--- a/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/SessionTextInput.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/SessionTextInput.java
@@ -531,18 +531,17 @@ public final class SessionTextInput {
         GeckoBundle response = null;
         EventCallback callback = null;
 
         for (int i = 0; i < values.size(); i++) {
             final int id = values.keyAt(i);
             final CharSequence value = values.valueAt(i);
 
             if (DEBUG) {
-                Log.d(LOGTAG,
-                      "performAutoFill(" + id + ", " + values + ')');
+                Log.d(LOGTAG, "performAutoFill(" + id + ')');
             }
             int rootId = id;
             for (int currentId = id; currentId != View.NO_ID; ) {
                 final GeckoBundle bundle = mAutoFillNodes.get(currentId);
                 if (bundle == null) {
                     return;
                 }
                 rootId = currentId;
--- a/mobile/android/modules/geckoview/GeckoViewAutoFill.jsm
+++ b/mobile/android/modules/geckoview/GeckoViewAutoFill.jsm
@@ -109,17 +109,17 @@ class GeckoViewAutoFill {
     const rootInfo = getInfo(aFormLike.rootElement, null, undefined);
     rootInfo.root = rootInfo.id;
     rootInfo.children = aFormLike.elements.map(
         element => getInfo(element, rootInfo.id, rootInfo.id));
 
     this._eventDispatcher.dispatch("GeckoView:AddAutoFill", rootInfo, {
       onSuccess: responses => {
         // `responses` is an object with IDs as keys.
-        debug `Performing auto-fill ${responses}`;
+        debug `Performing auto-fill ${Object.keys(responses)}`;
 
         const AUTOFILL_STATE = "-moz-autofill";
         const winUtils = window.windowUtils;
 
         for (let id in responses) {
           const entry = this._autoFillElements &&
                         this._autoFillElements.get(+id);
           const element = entry && entry.get();