Bug 1337073 - Improve the precision of the IPC_SYNC_LATENCY_MS probe and rename it to IPC_SYNC_MAIN_LATENCY_MS, r=billm a=gchang
authorMichael Layzell <michael@thelayzells.com>
Wed, 08 Mar 2017 17:53:50 -0500
changeset 395139 2024ba23cf5b68fda5d5079d0e38c9827b78d970
parent 395138 05c8e1058e9802bd77c34989e7e1abc82c0a36a1
child 395140 e71ac822186e5ff2f0503be03db08134b0969585
push id1468
push userasasaki@mozilla.com
push dateMon, 05 Jun 2017 19:31:07 +0000
treeherdermozilla-release@0641fc6ee9d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbillm, gchang
bugs1337073
milestone54.0a2
Bug 1337073 - Improve the precision of the IPC_SYNC_LATENCY_MS probe and rename it to IPC_SYNC_MAIN_LATENCY_MS, r=billm a=gchang MozReview-Commit-ID: 7JB7h06wCzu
ipc/glue/MessageChannel.cpp
toolkit/components/telemetry/Histograms.json
--- a/ipc/glue/MessageChannel.cpp
+++ b/ipc/glue/MessageChannel.cpp
@@ -1274,19 +1274,19 @@ MessageChannel::Send(Message* aMsg, Mess
     MOZ_RELEASE_ASSERT(reply->is_sync());
 
     *aReply = Move(*reply);
     if (aReply->size() >= kMinTelemetryMessageSize) {
         Telemetry::Accumulate(Telemetry::IPC_REPLY_SIZE,
                               nsDependentCString(msgName), aReply->size());
     }
 
-    // NOTE: Only collect IPC_SYNC_LATENCY_MS on the main thread (bug 1343729)
+    // NOTE: Only collect IPC_SYNC_MAIN_LATENCY_MS on the main thread (bug 1343729)
     if (NS_IsMainThread() && latencyMs >= kMinTelemetrySyncIPCLatencyMs) {
-      Telemetry::Accumulate(Telemetry::IPC_SYNC_LATENCY_MS,
+      Telemetry::Accumulate(Telemetry::IPC_SYNC_MAIN_LATENCY_MS,
                             nsDependentCString(msgName), latencyMs);
     }
     return true;
 }
 
 bool
 MessageChannel::Call(Message* aMsg, Message* aReply)
 {
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -10566,25 +10566,26 @@
     "bug_numbers": [1264820],
     "expires_in_version": "55",
     "kind": "exponential",
     "high": 8000000,
     "n_buckets": 50,
     "keyed": true,
     "description": "Measures the size of IPC messages by message name"
   },
-  "IPC_SYNC_LATENCY_MS": {
+  "IPC_SYNC_MAIN_LATENCY_MS": {
     "alert_emails": ["cpearce@mozilla.com"],
     "bug_numbers": [1333489],
     "expires_in_version": "60",
     "kind": "exponential",
-    "high": 2000,
-    "n_buckets": 10,
-    "keyed": true,
-    "description": "Measures the number of milliseconds we spend waiting for sync IPC messages to finish sending, keyed by message name. Note: only messages that wait for more than 500 microseconds are included in this probe."
+    "low": 32,
+    "high": 750,
+    "n_buckets": 40,
+    "keyed": true,
+    "description": "Measures the number of milliseconds we spend waiting for sync IPC messages to finish sending, keyed by message name. Note: only messages that wait for more than 500 microseconds and block the main thread are included in this probe."
   },
   "MESSAGE_MANAGER_MESSAGE_SIZE2": {
     "alert_emails": ["wmccloskey@mozilla.com","amccreight@mozilla.com"],
     "bug_numbers": [1260908],
     "expires_in_version": "55",
     "kind": "exponential",
     "low": 8192,
     "high": 8000000,