Bug 1376873 - Make lock_block explicit; r=bwc
authorDan Minor <dminor@mozilla.com>
Thu, 02 Aug 2018 13:56:10 -0400
changeset 504517 200849cab86aa098f75656f4e48d0ee34e82d240
parent 504516 cca0a311c33b82faa0039bf2547f3006b6cf6807
child 504518 92a7c3eee9f0c80ffbf79fdab8f8f2b8f6bd7701
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbwc
bugs1376873
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1376873 - Make lock_block explicit; r=bwc Differential Revision: https://phabricator.services.mozilla.com/D7468
media/mtransport/sigslot.h
--- a/media/mtransport/sigslot.h
+++ b/media/mtransport/sigslot.h
@@ -207,17 +207,17 @@ class multi_threaded_local {
 };
 #endif  // _SIGSLOT_HAS_POSIX_THREADS
 
 template <class mt_policy>
 class lock_block {
  public:
   mt_policy* m_mutex;
 
-  lock_block(mt_policy* mtx) : m_mutex(mtx) { m_mutex->lock(); }
+  explicit lock_block(mt_policy* mtx) : m_mutex(mtx) { m_mutex->lock(); }
 
   ~lock_block() { m_mutex->unlock(); }
 };
 
 class _signal_base_interface;
 
 class has_slots_interface {
  private: