Bug 1371266 - libpng should be built with -std=c89. r=glennrp
authorPetr Sumbera <petr.sumbera@oracle.com>
Thu, 08 Jun 2017 06:29:03 -0700
changeset 414693 1fd26e219e34f73fb72cca5d88e7ea9247b83f3d
parent 414692 6854e5bf150dc5a082d6c8b3dd03833bf677b519
child 414694 54a33646645e94211418e0444c83f2fbc0b15872
push id1517
push userjlorenzo@mozilla.com
push dateThu, 14 Sep 2017 16:50:54 +0000
treeherdermozilla-release@3b41fd564418 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglennrp
bugs1371266
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1371266 - libpng should be built with -std=c89. r=glennrp
media/libpng/moz.build
mozilla-config.h.in
--- a/media/libpng/moz.build
+++ b/media/libpng/moz.build
@@ -59,8 +59,11 @@ if CONFIG['MOZ_TREE_FREETYPE']:
     DEFINES['FT_CONFIG_OPTION_USE_PNG'] = True
 
 Library('mozpng')
 
 FINAL_LIBRARY = 'gkmedias'
 
 # We allow warnings for third-party code that can be updated from upstream.
 ALLOW_COMPILER_WARNINGS = True
+
+if CONFIG['GNU_CC']:
+    CFLAGS += ['-std=c89']
--- a/mozilla-config.h.in
+++ b/mozilla-config.h.in
@@ -8,17 +8,17 @@
 
 #if defined(__clang__)
 #pragma clang diagnostic push
 #if __has_warning("-Wreserved-id-macro")
 #pragma clang diagnostic ignored "-Wreserved-id-macro"
 #endif
 #endif
 
-// Expands to all the defines from configure.
+/* Expands to all the defines from configure. */
 #undef ALLDEFINES
 
 /*
  * The c99 defining the limit macros (UINT32_MAX for example), says:
  *
  *   C++ implementations should define these macros only when
  *   __STDC_LIMIT_MACROS is defined before <stdint.h> is included.
  *