Bug 1401085 - Make the opacity of the disabled back button consistent with other disabled toolbar buttons. r=dao
authorNihanth Subramanya <nhnt11@gmail.com>
Thu, 21 Sep 2017 05:12:59 +0530
changeset 435435 1f5e6917b9af3ef4d1ba0c1c874decaa834f8926
parent 435434 bb634fc6ef8c21c9d2ef86134c6e45a9b14f5138
child 435436 ad7b264c22cd23d59cd7c3d97899bbb60950811c
push id1618
push userCallek@gmail.com
push dateThu, 11 Jan 2018 17:45:48 +0000
treeherdermozilla-release@882ca853e05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1401085
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1401085 - Make the opacity of the disabled back button consistent with other disabled toolbar buttons. r=dao MozReview-Commit-ID: Lun7GjOZhmy
browser/themes/osx/browser.css
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -309,20 +309,24 @@
 .findbar-button {
   background: none;
   box-shadow: none;
   border: none;
 }
 
 /* On Mac, native buttons keep their full opacity when they become disabled
  * and only the glyph or text on top of them becomes less opaque. */
-#back-button[disabled="true"] > .toolbarbutton-icon {
+#main-window:not([customizing]) #back-button[disabled="true"] > .toolbarbutton-icon {
   opacity: 1 !important;
   -moz-context-properties: fill, fill-opacity;
-  fill-opacity: 0.4;
+  /* Disabled toolbar buttons get an opacity of 0.4 which multiplies
+   * their fill-opacity of 0.7. calc() doesn't work here - we'd need
+   * to multiply two unitless numbers and that's invalid in CSS, so
+   * we need to hard code the value for now. */
+  fill-opacity: 0.28;
 }
 
 /* Inactive elements are faded out on OSX */
 .toolbarbutton-1:not(:hover):-moz-window-inactive,
 #main-window:not([customizing]) .toolbarbutton-1:-moz-window-inactive[disabled="true"] {
   opacity: 0.5;
 }