Bug 977862 - dragging items onto an empty toolbar shows no drag outline in Australis' Customize Mode, r=mconley
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Sun, 09 Mar 2014 17:57:13 +0000
changeset 191332 1e331682951f1f77bfd4ee73a095809538a28848
parent 191220 8d1664e48b5967e72bd79b9a38e5ac15af6e263d
child 191333 569c2bd2234e2e7d71813d7f7235b1c7df596e3b
push id474
push userasasaki@mozilla.com
push dateMon, 02 Jun 2014 21:01:02 +0000
treeherdermozilla-release@967f4cf1b31c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley
bugs977862
milestone30.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 977862 - dragging items onto an empty toolbar shows no drag outline in Australis' Customize Mode, r=mconley
browser/components/customizableui/src/CustomizeMode.jsm
--- a/browser/components/customizableui/src/CustomizeMode.jsm
+++ b/browser/components/customizableui/src/CustomizeMode.jsm
@@ -1339,16 +1339,18 @@ CustomizeMode.prototype = {
 
     if (this._dragOverItem && dragOverItem != this._dragOverItem) {
       this._cancelDragActive(this._dragOverItem, dragOverItem);
     }
 
     if (dragOverItem != this._dragOverItem || dragValue != dragOverItem.getAttribute("dragover")) {
       if (dragOverItem != targetArea.customizationTarget) {
         this._setDragActive(dragOverItem, dragValue, draggedItemId, targetIsToolbar);
+      } else if (targetIsToolbar) {
+        this._updateToolbarCustomizationOutline(this.window, targetArea);
       }
       this._dragOverItem = dragOverItem;
     }
 
     aEvent.preventDefault();
     aEvent.stopPropagation();
   },