Bug 687298 - Prevent boolean setting checkboxes from getting two click events at once [r=mfinkle]
authorMatt Brubeck <mbrubeck@mozilla.com>
Mon, 19 Sep 2011 15:54:54 -0700
changeset 78479 1db035c0e495182631bd2a2beca272372d46af85
parent 78478 1b5705431f5ae7d7127498e08e30c08ed0368947
child 78480 c64b8574e28235e03e8f15331f99ff894bb51b76
push id78
push userclegnitto@mozilla.com
push dateFri, 16 Dec 2011 17:32:24 +0000
treeherdermozilla-release@79d24e644fdd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle
bugs687298
milestone9.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 687298 - Prevent boolean setting checkboxes from getting two click events at once [r=mfinkle]
mobile/chrome/content/bindings.xml
--- a/mobile/chrome/content/bindings.xml
+++ b/mobile/chrome/content/bindings.xml
@@ -1850,40 +1850,55 @@
           ContextHelper.showPopup({ target: aTextbox, json: json });
         ]]></body>
       </method>
     </implementation>
   </binding>
   
   <binding id="setting-fulltoggle-bool" extends="chrome://mozapps/content/extensions/setting.xml#setting-bool">
     <handlers>
+      <handler event="click" button="0" phase="capturing">
+        <![CDATA[
+        event.stopPropagation();
+        ]]>
+      </handler>
       <handler event="TapSingle" button="0" phase="capturing">
         <![CDATA[
         this.input.setChecked(!this.value);
         this.inputChanged();
         event.stopPropagation();
         ]]>
       </handler>
     </handlers>
   </binding>
 
   <binding id="setting-fulltoggle-boolint" extends="chrome://mozapps/content/extensions/setting.xml#setting-boolint">
     <handlers>
+      <handler event="click" button="0" phase="capturing">
+        <![CDATA[
+        event.stopPropagation();
+        ]]>
+      </handler>
       <handler event="TapSingle" button="0" phase="capturing">
         <![CDATA[
         this.input.setChecked(!this.value);
         this.inputChanged();
         event.stopPropagation();
         ]]>
       </handler>
     </handlers>
   </binding>
 
   <binding id="setting-fulltoggle-localized-bool" extends="chrome://mozapps/content/extensions/setting.xml#setting-localized-bool">
     <handlers>
+      <handler event="click" button="0" phase="capturing">
+        <![CDATA[
+        event.stopPropagation();
+        ]]>
+      </handler>
       <handler event="TapSingle" button="0" phase="capturing">
         <![CDATA[
         this.input.setChecked(!this.value);
         this.inputChanged();
         event.stopPropagation();
         ]]>
       </handler>
     </handlers>