Bug 1382724 - Capture select and input click events; r=me
authorJim Chen <nchen@mozilla.com>
Mon, 31 Jul 2017 17:54:06 -0400
changeset 423258 1b8336b8d1df74590bda11899d1caca738fbae32
parent 423257 559f7f92c891782597759947b89be636c2d4767b
child 423259 26d0c0e1c39e6151bda40d30720a9aeb229a1118
push id1517
push userjlorenzo@mozilla.com
push dateThu, 14 Sep 2017 16:50:54 +0000
treeherdermozilla-release@3b41fd564418 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1382724
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1382724 - Capture select and input click events; r=me Capture click events for select and input elements to restore previous behavior. This will always invoke helper prompts for those elements, even if scripts stop the click event propagation. r=me for trivial patch. MozReview-Commit-ID: KOfjc58Zb0Y
mobile/android/components/PromptService.js
--- a/mobile/android/components/PromptService.js
+++ b/mobile/android/components/PromptService.js
@@ -51,18 +51,18 @@ PromptService.prototype = {
         if (!this.selectHelper) {
           this.selectHelper = this.loadSubscript(
               "SelectHelper", "chrome://browser/content/SelectHelper.js");
         }
         if (!this.inputWidgetHelper) {
           this.inputWidgetHelper = this.loadSubscript(
               "InputWidgetHelper", "chrome://browser/content/InputWidgetHelper.js");
         }
-        win.addEventListener("click", this.selectHelper); // non-capture
-        win.addEventListener("click", this.inputWidgetHelper); // non-capture
+        win.addEventListener("click", this.selectHelper, /* capture */ true);
+        win.addEventListener("click", this.inputWidgetHelper, /* capture */ true);
         break;
       }
     }
   },
 
   /* ----------  nsIPromptFactory  ---------- */
   // XXX Copied from nsPrompter.js.
   getPrompt: function getPrompt(domWin, iid) {