Bug 1521338 - Don't dump anything in dumpScopeChain in more-deterministic builds. r=jorendorff a=NPOTB
authorJan de Mooij <jdemooij@mozilla.com>
Tue, 29 Jan 2019 23:06:11 +0000
changeset 515683 1b74fba653fb5c05548ec15f147c18770abf5ede
parent 515682 a3c2986ed43703fd724cb282ab6fa2ae1572a773
child 515684 ba19b54d3de7c5979e80c9e2a62336cae4aebdec
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorendorff, NPOTB
bugs1521338
milestone66.0
Bug 1521338 - Don't dump anything in dumpScopeChain in more-deterministic builds. r=jorendorff a=NPOTB Differential Revision: https://phabricator.services.mozilla.com/D17503
js/src/shell/js.cpp
--- a/js/src/shell/js.cpp
+++ b/js/src/shell/js.cpp
@@ -7663,17 +7663,21 @@ static bool DumpScopeChain(JSContext* cx
   } else {
     script = obj->as<ModuleObject>().maybeScript();
     if (!script) {
       JS_ReportErrorASCII(cx, "module does not have an associated script");
       return false;
     }
   }
 
+#ifndef JS_MORE_DETERMINISTIC
+  // Don't dump anything in more-deterministic builds because the output
+  // includes pointer values.
   script->bodyScope()->dump();
+#endif
 
   args.rval().setUndefined();
   return true;
 }
 
 // For testing gray marking, grayRoot() will heap-allocate an address
 // where we can store a JSObject*, and create a new object if one doesn't
 // already exist.