Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (setup ESLint). r=mossop
authorMark Banner <standard8@mozilla.com>
Fri, 19 Oct 2018 08:46:31 +0000
changeset 500639 1ac84aa579d69572a6569e70b73c1e17d206361e
parent 500638 988056e6d0543949b91fd7501ab4140f88e087e6
child 500640 0cb99356070d3f79a1ff20c64970d092b7d908c5
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmossop
bugs1486741
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (setup ESLint). r=mossop Depends on D8391 Differential Revision: https://phabricator.services.mozilla.com/D8392
.eslintrc.js
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -34,32 +34,10 @@ module.exports = {
       "browser/base/content/urlbarBindings.xml",
       "browser/components/search/content/search.xml",
       "browser/components/translation/translation-infobar.xml",
       "toolkit/components/prompts/content/tabprompts.xml"
     ],
     "env": {
       "mozilla/browser-window": true
     }
-  }, {
-    // XXX Bug 1486741 - We've not rolled out comma-dangle to these directories
-    // yet, so turn it off for now.
-    "files": [
-      "accessible/**",
-      "caps/**",
-      "chrome/**",
-      "devtools/**",
-      "dom/**",
-      "extensions/**",
-      "intl/**",
-      "js/**",
-      "mobile/**",
-      "security/**",
-      "storage/**",
-      "testing/**",
-      "tools/**",
-      "xpcom/**",
-    ],
-    "rules": {
-      "comma-dangle": "off",
-    }
   }]
 };