Bug 1457488 - Improve error message with lower-case environment variable; r=chmanchester
authorMs2ger <Ms2ger@igalia.com>
Wed, 02 May 2018 11:59:32 +0200
changeset 472733 193ffb14b691d979d870442a213d93496777c0a7
parent 472732 5c7c2345902694097230a1b6e6bda9bd3c827743
child 472734 fb4c2185ba0136e48e58cad409dae119dd16fdeb
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerschmanchester
bugs1457488
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1457488 - Improve error message with lower-case environment variable; r=chmanchester
python/mozbuild/mozbuild/configure/options.py
--- a/python/mozbuild/mozbuild/configure/options.py
+++ b/python/mozbuild/mozbuild/configure/options.py
@@ -271,17 +271,17 @@ class Option(object):
                                                  'with', 'without'):
                 return prefix, elements[1], values
         else:
             if name.startswith('-'):
                 raise InvalidOptionError(
                     'Option must start with two dashes instead of one')
             if name.islower():
                 raise InvalidOptionError(
-                    'Environment variable name must be all uppercase')
+                    'Environment variable name "%s" must be all uppercase' % name)
         return '', name, values
 
     @staticmethod
     def _join_option(prefix, name):
         # The constraints around name and env in __init__ make it so that
         # we can distinguish between flags and environment variables with
         # islower/isupper.
         if name.isupper():