Bug 1413941 - Fix broken netmonitor launchpad regression from bug 1360457 r=Honza
authorRicky Chien <ricky060709@gmail.com>
Thu, 02 Nov 2017 22:40:44 +0800
changeset 443220 180cd6b0a9748b0de0c563a7d58d8be7eedc94c8
parent 443219 e6d86b7284bae701700b9d300ee1476ebe5f3eed
child 443221 6af2bb14bd4c1ada3e9dc68ff9c40b3a9e0893e0
push id1618
push userCallek@gmail.com
push dateThu, 11 Jan 2018 17:45:48 +0000
treeherdermozilla-release@882ca853e05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza
bugs1413941, 1360457
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1413941 - Fix broken netmonitor launchpad regression from bug 1360457 r=Honza MozReview-Commit-ID: 6EzLlNfQ4FX
devtools/client/netmonitor/src/components/RequestList.js
devtools/client/netmonitor/src/components/RequestListEmptyNotice.js
devtools/client/netmonitor/src/components/Toolbar.js
--- a/devtools/client/netmonitor/src/components/RequestList.js
+++ b/devtools/client/netmonitor/src/components/RequestList.js
@@ -21,21 +21,22 @@ const { div } = DOM;
  * Request panel component
  */
 function RequestList({
   connector,
   isEmpty,
 }) {
   return (
     div({ className: "request-list-container" },
-      isEmpty ? RequestListEmptyNotice({connector}) : RequestListContent({connector}),
-      StatusBar(),
+      isEmpty ? RequestListEmptyNotice({ connector }) : RequestListContent({ connector }),
+      StatusBar({ connector }),
     )
   );
 }
 
 RequestList.displayName = "RequestList";
 
 RequestList.propTypes = {
+  connector: PropTypes.object.isRequired,
   isEmpty: PropTypes.bool.isRequired,
 };
 
 module.exports = RequestList;
--- a/devtools/client/netmonitor/src/components/RequestListEmptyNotice.js
+++ b/devtools/client/netmonitor/src/components/RequestListEmptyNotice.js
@@ -55,17 +55,17 @@ class RequestListEmptyNotice extends Com
             className: "devtools-button requests-list-reload-notice-button",
             "data-standalone": true,
             onClick: this.props.onReloadClick,
           },
           RELOAD_NOTICE_2
         ),
         span(null, RELOAD_NOTICE_3)
       ),
-      div({ className: "notice-perf-message" },
+      div({ className: "notice-perf-message empty-notice-element" },
         span(null, PERFORMANCE_NOTICE_1),
         button({
           title: PERFORMANCE_NOTICE_3,
           className: "devtools-button requests-list-perf-notice-button",
           "data-standalone": true,
           onClick: this.props.onPerfClick,
         }),
         span(null, PERFORMANCE_NOTICE_2),
--- a/devtools/client/netmonitor/src/components/Toolbar.js
+++ b/devtools/client/netmonitor/src/components/Toolbar.js
@@ -197,31 +197,31 @@ class Toolbar extends Component {
               className: "devtools-checkbox-label",
               title: ENABLE_PERSISTENT_LOGS_TOOLTIP,
             },
             input({
               id: "devtools-persistlog-checkbox",
               className: "devtools-checkbox",
               type: "checkbox",
               checked: persistentLogsEnabled,
-              onClick: togglePersistentLogs,
+              onChange: togglePersistentLogs,
             }),
             ENABLE_PERSISTENT_LOGS_LABEL
           ),
           label(
             {
               className: "devtools-checkbox-label",
               title: DISABLE_CACHE_TOOLTIP,
             },
             input({
               id: "devtools-cache-checkbox",
               className: "devtools-checkbox",
               type: "checkbox",
               checked: browserCacheDisabled,
-              onClick: toggleBrowserCache,
+              onChange: toggleBrowserCache,
             }),
             DISABLE_CACHE_LABEL,
           ),
         ),
         span({ className: "devtools-toolbar-group" },
           SearchBox({
             delay: FILTER_SEARCH_DELAY,
             keyShortcut: SEARCH_KEY_SHORTCUT,