Bug 1512278 - add empty alt text to ToolboxTab icon; r=pbro
authorFlorens Verschelde <florens@fvsch.com>
Thu, 06 Dec 2018 07:58:15 +0000
changeset 508730 17e2efc3d047c9a3510abfda46b2ac163975abd5
parent 508729 32b8595b7c207bec915e39450d565ada6f50bc48
child 508731 72412ffdc228936b39ab9392f7ec768aaff33665
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspbro
bugs1512278
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1512278 - add empty alt text to ToolboxTab icon; r=pbro Differential Revision: https://phabricator.services.mozilla.com/D13865
devtools/client/framework/components/ToolboxTab.js
--- a/devtools/client/framework/components/ToolboxTab.js
+++ b/devtools/client/framework/components/ToolboxTab.js
@@ -21,23 +21,24 @@ class ToolboxTab extends Component {
     };
   }
 
   constructor(props) {
     super(props);
     this.renderIcon = this.renderIcon.bind(this);
   }
 
-  renderIcon(definition, isHighlighted) {
+  renderIcon(definition) {
     const {icon} = definition;
     if (!icon) {
       return [];
     }
     return [
       img({
+        alt: "",
         src: icon,
       }),
     ];
   }
 
   render() {
     const {panelDefinition, currentToolId, highlightedTools, selectTool,
            focusedButton, focusButton} = this.props;
@@ -69,17 +70,17 @@ class ToolboxTab extends Component {
           }
         },
       },
       span(
         {
           className: "devtools-tab-line",
         }
       ),
-      ...this.renderIcon(panelDefinition, isHighlighted),
+      ...this.renderIcon(panelDefinition),
       iconOnly ?
         null :
         span(
           {
             className: "devtools-tab-label",
           },
           label,
           badge && !isHighlighted ?