author | Michael Layzell <michael@thelayzells.com> |
Wed, 07 Sep 2016 13:48:23 -0400 | |
changeset 356575 | 15dfa78b6aabea262599bcb452ab606d876d78c3 |
parent 356574 | 0e851843cf5a65f8570dbc3f99ab16243b2bb307 |
child 356576 | c2115d200aebfcf50507302c26e6ffc3c9ba12ec |
push id | 1324 |
push user | mtabara@mozilla.com |
push date | Mon, 16 Jan 2017 13:07:44 +0000 |
treeherder | mozilla-release@a01c49833940 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | smaug |
bugs | 1301127 |
milestone | 51.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
storage/mozStorageAsyncStatementExecution.cpp | file | annotate | diff | comparison | revisions | |
toolkit/components/places/nsNavHistoryResult.cpp | file | annotate | diff | comparison | revisions |
--- a/storage/mozStorageAsyncStatementExecution.cpp +++ b/storage/mozStorageAsyncStatementExecution.cpp @@ -65,20 +65,17 @@ public: NS_IMETHOD Run() override { NS_ASSERTION(mCallback, "Trying to notify about results without a callback!"); if (mEventStatus->shouldNotify()) { // Hold a strong reference to the callback while notifying it, so that if // it spins the event loop, the callback won't be released and freed out // from under us. - // - // We can't put it in a nsCOMPtr, as sometimes mCallback doesn't - // QueryInterface to a mozIStorageStatementCallback, despite being one - RefPtr<mozIStorageStatementCallback> callback = mCallback; + nsCOMPtr<mozIStorageStatementCallback> callback = mCallback; (void)callback->HandleResult(mResults); } return NS_OK; } private: @@ -103,20 +100,17 @@ public: } NS_IMETHOD Run() override { if (mEventStatus->shouldNotify() && mCallback) { // Hold a strong reference to the callback while notifying it, so that if // it spins the event loop, the callback won't be released and freed out // from under us. - // - // We can't put it in a nsCOMPtr, as sometimes mCallback doesn't - // QueryInterface to a mozIStorageStatementCallback, despite being one - RefPtr<mozIStorageStatementCallback> callback = mCallback; + nsCOMPtr<mozIStorageStatementCallback> callback = mCallback; (void)callback->HandleError(mErrorObj); } return NS_OK; } private:
--- a/toolkit/components/places/nsNavHistoryResult.cpp +++ b/toolkit/components/places/nsNavHistoryResult.cpp @@ -3009,17 +3009,18 @@ nsNavHistoryQueryResultNode::OnItemMoved * operations to keep ourselves in sync with the bookmark service. If the * folder is closed, we just clear our list to mark it as invalid and * unregister as a listener. This means we do not have to keep maintaining * an up-to-date list for the entire bookmark menu structure in every place * it is used. */ NS_IMPL_ISUPPORTS_INHERITED(nsNavHistoryFolderResultNode, nsNavHistoryContainerResultNode, - nsINavHistoryQueryResultNode) + nsINavHistoryQueryResultNode, + mozIStorageStatementCallback) nsNavHistoryFolderResultNode::nsNavHistoryFolderResultNode( const nsACString& aTitle, nsNavHistoryQueryOptions* aOptions, int64_t aFolderId) : nsNavHistoryContainerResultNode(EmptyCString(), aTitle, EmptyCString(), nsNavHistoryResultNode::RESULT_TYPE_FOLDER, aOptions), mContentsValid(false),