Bug 1231169 - report rust mp4parse track status in telemetry. r=kinetik,vladan
authorRalph Giles <giles@mozilla.com>
Fri, 11 Dec 2015 12:51:00 -0800
changeset 313623 1526190a14f11a24c4c5934d03cb7fc591a50516
parent 313622 b9e20e475147deee754084404c52559f928f6232
child 313624 b5dcc2d9ccd71dc84584275b1effe6a3da878c70
push id1079
push userjlund@mozilla.com
push dateFri, 15 Apr 2016 21:02:33 +0000
treeherdermozilla-release@575fbf6786d5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskinetik, vladan
bugs1231169
milestone46.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1231169 - report rust mp4parse track status in telemetry. r=kinetik,vladan
media/libstagefright/binding/MP4Metadata.cpp
toolkit/components/telemetry/Histograms.json
--- a/media/libstagefright/binding/MP4Metadata.cpp
+++ b/media/libstagefright/binding/MP4Metadata.cpp
@@ -195,16 +195,28 @@ MP4Metadata::GetNumberTracks(mozilla::Tr
       default:
         break;
       }
     }
   }
   static LazyLogModule sLog("MP4Metadata");
   MOZ_LOG(sLog, LogLevel::Info, ("%s tracks found: stagefright=%u rust=%u",
                                  rust_track_type, total, rust_total));
+  switch (aType) {
+    case mozilla::TrackInfo::kAudioTrack:
+      Telemetry::Accumulate(Telemetry::MEDIA_RUST_MP4PARSE_TRACK_MATCH_AUDIO,
+                            rust_total == total);
+      break;
+    case mozilla::TrackInfo::kVideoTrack:
+      Telemetry::Accumulate(Telemetry::MEDIA_RUST_MP4PARSE_TRACK_MATCH_VIDEO,
+                            rust_total == total);
+      break;
+    default:
+      break;
+  }
 #endif
   return total;
 }
 
 mozilla::UniquePtr<mozilla::TrackInfo>
 MP4Metadata::GetTrackInfo(mozilla::TrackInfo::TrackType aType,
                           size_t aTrackNumber) const
 {
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -6274,16 +6274,32 @@
     "description": "The time (in milliseconds) that it took a 'reconfigure thread' request to go round trip."
   },
   "MEDIA_RUST_MP4PARSE_SUCCESS": {
     "expires_in_version": "50",
     "kind": "boolean",
     "description": "(Bug 1220885) Whether the rust mp4 demuxer successfully parsed a stream segment.",
     "cpp_guard": "MOZ_RUST_MP4PARSE"
   },
+  "MEDIA_RUST_MP4PARSE_TRACK_MATCH_AUDIO": {
+    "alert_emails": ["giles@mozilla.com", "kinetik@flim.org"],
+    "expires_in_version": "50",
+    "kind": "boolean",
+    "bug_numbers": [1231169],
+    "description": "Whether rust and stagefight mp4 parser audio track results match.",
+    "cpp_guard": "MOZ_RUST_MP4PARSE"
+  },
+  "MEDIA_RUST_MP4PARSE_TRACK_MATCH_VIDEO": {
+    "alert_emails": ["giles@mozilla.com", "kinetik@flim.org"],
+    "expires_in_version": "50",
+    "kind": "boolean",
+    "bug_numbers": [1231169],
+    "description": "Whether rust and stagefight mp4 parser video track results match.",
+    "cpp_guard": "MOZ_RUST_MP4PARSE"
+  },
   "MEDIA_WMF_DECODE_ERROR": {
     "expires_in_version": "50",
     "kind": "enumerated",
     "n_values": 256,
     "description": "WMF media decoder error or success (0) codes."
   },
   "MEDIA_OGG_LOADED_IS_CHAINED": {
     "alert_emails": ["cpearce@mozilla.com"],