Bug 1538013 - fix sidebar icon in fxa menu to be correct in RTL and when the sidebar is moved, r=johannh, a=pascalc DEVEDITION_67_0b7_BUILD1 DEVEDITION_67_0b7_RELEASE FENNEC_67_0b7_BUILD1 FENNEC_67_0b7_RELEASE FIREFOX_67_0b7_BUILD1 FIREFOX_67_0b7_RELEASE
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Fri, 22 Mar 2019 13:31:35 +0000
changeset 525851 13d26dc811fe304c8c38bb4b6da79020467164b1
parent 525850 329f98e8ad66162f5565e20ccf81493b74d4f26a
child 525852 690f6794cdd246ac827df9e9defbc6d36eaa4977
push id2032
push userffxbld-merge
push dateMon, 13 May 2019 09:36:57 +0000
treeherdermozilla-release@455c1065dcbe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjohannh, pascalc
bugs1538013
milestone67.0
Bug 1538013 - fix sidebar icon in fxa menu to be correct in RTL and when the sidebar is moved, r=johannh, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D24500
browser/components/customizableui/content/panelUI.inc.xul
browser/themes/shared/menupanel.inc.css
--- a/browser/components/customizableui/content/panelUI.inc.xul
+++ b/browser/components/customizableui/content/panelUI.inc.xul
@@ -752,17 +752,19 @@
           <toolbarbutton id="PanelUI-fxa-menu-remotetabs-button"
                          class="subviewbutton subviewbutton-iconic subviewbutton-nav"
                          label="&appMenuRemoteTabs.label;"
                          closemenu="none"
                          oncommand="PanelUI.showSubView('PanelUI-remotetabs', this)"/>
           <toolbarbutton id="PanelUI-fxa-menu-view-sidebar"
                          class="subviewbutton subviewbutton-iconic"
                          label="&appMenuRemoteTabs.sidebar.label;"
-                         oncommand="SidebarUI.toggle('viewTabsSidebar');"/>
+                         oncommand="SidebarUI.toggle('viewTabsSidebar');">
+            <observes element="sidebar-box" attribute="positionend"/>
+          </toolbarbutton>
           <toolbarseparator/>
           <toolbarbutton class="subviewbutton" label="&fxa.menu.connectAnotherDevice.label;" oncommand="gSync.openConnectAnotherDevice('fxa_discoverability_native');"/>
           <toolbarbutton class="subviewbutton" label="&fxa.menu.manageAccount.label;" oncommand="gSync.openFxAManagePage('fxa_discoverability_native');"/>
           <toolbarbutton class="subviewbutton" label="&fxa.menu.syncSettings.label;" oncommand="gSync.openPrefs('fxa_discoverability_native');"/>
           <toolbarseparator/>
           <toolbarbutton id="PanelUI-fxa-menu-syncnow-button"
                          label="&syncSyncNowItem.label;"
                          syncinglabel="&syncSyncNowItemSyncing.label;"
--- a/browser/themes/shared/menupanel.inc.css
+++ b/browser/themes/shared/menupanel.inc.css
@@ -103,16 +103,18 @@
 
 #PanelUI-fxa-menu-view-sidebar,
 #appMenuViewHistorySidebar,
 #PanelUI-remotetabs-view-sidebar,
 #panelMenu_viewBookmarksSidebar {
   list-style-image: url("chrome://browser/skin/sidebars-right.svg");
 }
 
+#PanelUI-fxa-menu-view-sidebar:-moz-locale-dir(ltr):not([positionend]),
+#PanelUI-fxa-menu-view-sidebar:-moz-locale-dir(rtl)[positionend],
 #appMenuViewHistorySidebar:-moz-locale-dir(ltr):not([positionend]),
 #appMenuViewHistorySidebar:-moz-locale-dir(rtl)[positionend],
 #PanelUI-remotetabs-view-sidebar:-moz-locale-dir(ltr):not([positionend]),
 #PanelUI-remotetabs-view-sidebar:-moz-locale-dir(rtl)[positionend],
 #panelMenu_viewBookmarksSidebar:-moz-locale-dir(ltr):not([positionend]),
 #panelMenu_viewBookmarksSidebar:-moz-locale-dir(rtl)[positionend] {
   list-style-image: url("chrome://browser/skin/sidebars.svg");
 }