Bug 1467407 - Fix incorrect usage of ok() in devtools keyboard nav mochitest;r=yzen
authorJulian Descottes <jdescottes@mozilla.com>
Thu, 07 Jun 2018 12:03:47 +0200
changeset 478661 13714116865dee4843b17d7be7bdac84f0eac0a2
parent 478660 5b8df05804e2a02162b601ad576944d462baef41
child 478662 79e6b5e97fed0a861be04fa3635e5033ef9580f4
push id1757
push userffxbld-merge
push dateFri, 24 Aug 2018 17:02:43 +0000
treeherdermozilla-release@736023aebdb1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersyzen
bugs1467407
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1467407 - Fix incorrect usage of ok() in devtools keyboard nav mochitest;r=yzen MozReview-Commit-ID: 3LGuqjnWYRA
devtools/client/framework/test/browser_toolbox_keyboard_navigation.js
--- a/devtools/client/framework/test/browser_toolbox_keyboard_navigation.js
+++ b/devtools/client/framework/test/browser_toolbox_keyboard_navigation.js
@@ -102,25 +102,27 @@ add_task(async function() {
   // Move the focused tab and select it by using enter key.
   let onKeyEvent = once(win, "keydown");
   EventUtils.synthesizeKey("KEY_ArrowRight");
   await onKeyEvent;
 
   let onceSelected = toolbox.once("webconsole-selected");
   EventUtils.synthesizeKey("Enter");
   await onceSelected;
-  ok(doc.activeElement.id, tabButtons[1].id, "Changed tab button is focused.");
+  is(doc.activeElement.id, "toolbox-panel-iframe-" + toolbox.currentToolId,
+    "Selected tool frame is now focused.");
 
   // Webconsole steal the focus from button after sending "webconsole-selected"
   // event.
   tabButtons[1].focus();
 
   // Return the focused tab with space key.
   onKeyEvent = once(win, "keydown");
   EventUtils.synthesizeKey("KEY_ArrowLeft");
   await onKeyEvent;
 
   onceSelected = toolbox.once("inspector-selected");
   EventUtils.synthesizeKey(" ");
   await onceSelected;
 
-  ok(doc.activeElement.id, tabButtons[0].id, "Changed tab button is focused.");
+  is(doc.activeElement.id, "toolbox-panel-iframe-" + toolbox.currentToolId,
+    "Selected tool frame is now focused.");
 });