Bug 1522138 - [release 120] put log points behind a flag (#7761). r=dwalsh
authorHubert Boma Manilla <b4bomsy@gmail.com>
Thu, 24 Jan 2019 15:23:47 -0500
changeset 515388 10b38250b65ef6c43aceb38402e254f18b8a60ec
parent 515387 d05ea5ad794548a57ae9792feead7228c201125a
child 515389 38d9045b04e6ac6debe87dcfa42322a24359eebd
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdwalsh
bugs1522138
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1522138 - [release 120] put log points behind a flag (#7761). r=dwalsh
devtools/client/debugger/new/src/components/Editor/GutterMenu.js
devtools/client/debugger/new/src/utils/prefs.js
devtools/client/preferences/debugger.js
--- a/devtools/client/debugger/new/src/components/Editor/GutterMenu.js
+++ b/devtools/client/debugger/new/src/components/Editor/GutterMenu.js
@@ -115,17 +115,21 @@ export function gutterMenu({
         breakpoint ? breakpoint.location : { line, column, sourceId }
       ),
     accelerator: L10N.getStr("toggleCondPanel.key"),
     ...(breakpoint && breakpoint.condition
       ? gutterItems.editConditional
       : gutterItems.addConditional)
   };
 
-  let items = [toggleBreakpointItem, conditionalBreakpoint, logPoint];
+  let items = [toggleBreakpointItem, conditionalBreakpoint];
+  
+  if (features.logPoints) {
+    items.push(logPoint)
+  }
 
   if (breakpoint && breakpoint.condition) {
     const remove = breakpoint.log ? conditionalBreakpoint : logPoint;
     items = items.filter(item => item !== remove);
   }
 
   if (isPaused) {
     const continueToHereItem = {
--- a/devtools/client/debugger/new/src/utils/prefs.js
+++ b/devtools/client/debugger/new/src/utils/prefs.js
@@ -60,16 +60,17 @@ if (isDevelopment()) {
   pref("devtools.debugger.features.component-pane", false);
   pref("devtools.debugger.features.autocomplete-expressions", false);
   pref("devtools.debugger.features.map-expression-bindings", true);
   pref("devtools.debugger.features.map-await-expression", true);
   pref("devtools.debugger.features.xhr-breakpoints", true);
   pref("devtools.debugger.features.original-blackbox", true);
   pref("devtools.debugger.features.windowless-workers", false);
   pref("devtools.debugger.features.event-listeners-breakpoints", true);
+  pref("devtools.debugger.features.log-points", true);
 }
 
 export const prefs = new PrefsHelper("devtools", {
   logging: ["Bool", "debugger.alphabetize-outline"],
   alphabetizeOutline: ["Bool", "debugger.alphabetize-outline"],
   autoPrettyPrint: ["Bool", "debugger.auto-pretty-print"],
   clientSourceMapsEnabled: ["Bool", "source-map.client-service.enabled"],
   pauseOnExceptions: ["Bool", "debugger.pause-on-exceptions"],
@@ -116,17 +117,18 @@ export const features = new PrefsHelper(
   pausePoints: ["Bool", "pause-points"],
   skipPausing: ["Bool", "skip-pausing"],
   autocompleteExpression: ["Bool", "autocomplete-expressions"],
   mapExpressionBindings: ["Bool", "map-expression-bindings"],
   mapAwaitExpression: ["Bool", "map-await-expression"],
   componentPane: ["Bool", "component-pane"],
   xhrBreakpoints: ["Bool", "xhr-breakpoints"],
   originalBlackbox: ["Bool", "original-blackbox"],
-  eventListenersBreakpoints: ["Bool", "event-listeners-breakpoints"]
+  eventListenersBreakpoints: ["Bool", "event-listeners-breakpoints"],
+  logPoints: ["Bool", "log-points"]
 });
 
 export const asyncStore = asyncStoreHelper("debugger", {
   pendingBreakpoints: ["pending-breakpoints", {}],
   tabs: ["tabs", []],
   xhrBreakpoints: ["xhr-breakpoints", []],
   eventListenerBreakpoints: ["event-listener-breakpoints", []]
 });
--- a/devtools/client/preferences/debugger.js
+++ b/devtools/client/preferences/debugger.js
@@ -67,8 +67,9 @@ pref("devtools.debugger.features.compone
 pref("devtools.debugger.features.async-stepping", true);
 pref("devtools.debugger.features.skip-pausing", true);
 pref("devtools.debugger.features.autocomplete-expressions", false);
 pref("devtools.debugger.features.map-expression-bindings", true);
 pref("devtools.debugger.features.xhr-breakpoints", true);
 pref("devtools.debugger.features.original-blackbox", true);
 pref("devtools.debugger.features.windowless-workers", false);
 pref("devtools.debugger.features.event-listeners-breakpoints", false);
+pref("devtools.debugger.features.log-points", false);