Bug 1496297 - Use |jit-test| skip-if as appropriate in jit-test/tests/parser/ (r=jorendorff)
authorEric Faust <efausbmo@gmail.com>
Tue, 09 Oct 2018 15:41:50 -0700
changeset 498843 0fb70553886a17318a1ef26a5b0ffc063ed4b9ae
parent 498842 ca4e8e9425aeb3545b3c3788a953fcd93359e26a
child 498844 178e8e65a1a3874bb7215043af0ba12df06120a8
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorendorff
bugs1496297
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1496297 - Use |jit-test| skip-if as appropriate in jit-test/tests/parser/ (r=jorendorff)
js/src/jit-test/tests/parser/bug-1263355-44.js
js/src/jit-test/tests/parser/bug-1263355-48.js
js/src/jit-test/tests/parser/bug-1324773-2.js
js/src/jit-test/tests/parser/bug-1324773.js
js/src/jit-test/tests/parser/bug-1431353-2.js
js/src/jit-test/tests/parser/bug-1431353.js
js/src/jit-test/tests/parser/bug-1433014.js
js/src/jit-test/tests/parser/bug-1465695.js
js/src/jit-test/tests/parser/bug-1470992.js
js/src/jit-test/tests/parser/bug1461034.js
--- a/js/src/jit-test/tests/parser/bug-1263355-44.js
+++ b/js/src/jit-test/tests/parser/bug-1263355-44.js
@@ -1,9 +1,8 @@
-if (!('oomTest' in this))
-  quit();
+// |jit-test| skip-if: !('oomTest' in this)
 
 // Adapted from randomly chosen test: js/src/jit-test/tests/profiler/bug1231925.js
 "use strict";
 enableGeckoProfiling();
 oomTest(function() {
     eval("(function() {})()");
 });
--- a/js/src/jit-test/tests/parser/bug-1263355-48.js
+++ b/js/src/jit-test/tests/parser/bug-1263355-48.js
@@ -1,10 +1,9 @@
-if (helperThreadCount() == 0)
-  quit();
+// |jit-test| skip-if: helperThreadCount() === 0
 
 function eval(source) {
     offThreadCompileModule(source);
     let m = finishOffThreadModule();
     m.declarationInstantiation();
     return m.evaluation();
 }
 function runTestCase(testcase) {
--- a/js/src/jit-test/tests/parser/bug-1324773-2.js
+++ b/js/src/jit-test/tests/parser/bug-1324773-2.js
@@ -1,10 +1,10 @@
-if (!('gczeal' in this))
-    quit();
+// |jit-test| skip-if: !('gczeal' in this)
+
 var lfGlobal = newGlobal();
 lfGlobal.evaluate(`
     for (var i = 0; i < 600; i++)
         eval('function f' + i + '() {}');
 `);
 var lfGlobal = newGlobal();
 lfGlobal.evaluate(`
     if (!('gczeal' in this))
--- a/js/src/jit-test/tests/parser/bug-1324773.js
+++ b/js/src/jit-test/tests/parser/bug-1324773.js
@@ -1,10 +1,10 @@
-if (!('gczeal' in this))
-    quit();
+// |jit-test| skip-if: !('gczeal' in this)
+
 var lfGlobal = newGlobal();
 lfGlobal.evaluate(`
     for (var i = 0; i < 600; i++)
         eval('function f' + i + '() {}');
 `);
 var lfGlobal = newGlobal();
 lfGlobal.evaluate(`
     if (!('gczeal' in this))
--- a/js/src/jit-test/tests/parser/bug-1431353-2.js
+++ b/js/src/jit-test/tests/parser/bug-1431353-2.js
@@ -1,14 +1,13 @@
+// |jit-test| skip-if: helperThreadCount() === 0
+
 // Test off-thread parsing correctly fixes up prototypes of special objects when
 // merging back to the target compartment.
 
-if (helperThreadCount() === 0)
-    quit();
-
 function execOffThread(source)
 {
     offThreadCompileScript(source);
     return runOffThreadScript();
 }
 
 function parseModuleOffThread(source)
 {
--- a/js/src/jit-test/tests/parser/bug-1431353.js
+++ b/js/src/jit-test/tests/parser/bug-1431353.js
@@ -1,12 +1,11 @@
-// Test multiple concurrent off-thread parse jobs.
+// |jit-test| skip-if: helperThreadCount() === 0
 
-if (helperThreadCount() === 0)
-    quit();
+// Test multiple concurrent off-thread parse jobs.
 
 function assertFails(f) {
     let failed = false;
     try {
         f();
     } catch (e) {
         failed = true;
     }
--- a/js/src/jit-test/tests/parser/bug-1433014.js
+++ b/js/src/jit-test/tests/parser/bug-1433014.js
@@ -1,11 +1,6 @@
-if (helperThreadCount() === 0)
-    quit();
-
-if (!('oomTest' in this))
-    quit();
-
+// |jit-test| skip-if: helperThreadCount() === 0 || !('oomTest' in this)
 options('strict');
 evaluate(`
     oomTest(() => {
         offThreadCompileScript("");
     });`);
--- a/js/src/jit-test/tests/parser/bug-1465695.js
+++ b/js/src/jit-test/tests/parser/bug-1465695.js
@@ -1,4 +1,3 @@
-if (helperThreadCount() === 0)
-    quit();
+// |jit-test| skip-if: helperThreadCount() === 0
 for (let x = 0; x < 99; ++x)
     evalInWorker("newGlobal().offThreadCompileScript(\"{}\");");
--- a/js/src/jit-test/tests/parser/bug-1470992.js
+++ b/js/src/jit-test/tests/parser/bug-1470992.js
@@ -1,5 +1,4 @@
-if (helperThreadCount() === 0)
-    quit();
+// |jit-test| skip-if: helperThreadCount() === 0
 
 offThreadCompileModule("export { x };");
 gcslice(10);
--- a/js/src/jit-test/tests/parser/bug1461034.js
+++ b/js/src/jit-test/tests/parser/bug1461034.js
@@ -1,3 +1,2 @@
-if (!('oomTest' in this))
-    quit();
+// |jit-test| skip-if: !('oomTest' in this)
 oomTest(function(){s[-1]});