Bug 1458414 - Enable test_animation_omta.html on WebRender. r=kats
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Wed, 02 May 2018 12:15:05 +0900
changeset 472793 0f766b153ebfa687db83256ccc9be55730732fea
parent 472792 af61a9b83a656716510eae964d10bf2153ff90eb
child 472794 9f6c1ddff4996ea26b2fcda3bd1f3d0925c6f338
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskats
bugs1458414, 1456679
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1458414 - Enable test_animation_omta.html on WebRender. r=kats But some test cases are skipped, they will be enabled in bug 1456679. MozReview-Commit-ID: HLxPjkf6KjY
layout/style/test/mochitest.ini
layout/style/test/test_animations_omta.html
--- a/layout/style/test/mochitest.ini
+++ b/layout/style/test/mochitest.ini
@@ -53,17 +53,16 @@ support-files = Ahem.ttf file_animations
 [test_animations_dynamic_changes.html]
 [test_animations_effect_timing_duration.html]
 [test_animations_effect_timing_enddelay.html]
 [test_animations_effect_timing_iterations.html]
 [test_animations_event_order.html]
 [test_animations_event_handler_attribute.html]
 [test_animations_iterationstart.html]
 [test_animations_omta.html]
-skip-if = webrender # bug 1424752
 [test_animations_omta_start.html]
 [test_animations_pausing.html]
 [test_animations_playbackrate.html]
 [test_animations_reverse.html]
 [test_animations_styles_on_event.html]
 [test_animations_variable_changes.html]
 [test_animations_with_disabled_properties.html]
 support-files = file_animations_with_disabled_properties.html
--- a/layout/style/test/test_animations_omta.html
+++ b/layout/style/test/test_animations_omta.html
@@ -176,16 +176,19 @@ https://bugzilla.mozilla.org/show_bug.cg
 <a target="_blank"
   href="https://bugzilla.mozilla.org/show_bug.cgi?id=964646">Mozilla Bug
   964646</a>
 <div id="display"></div>
 <pre id="test">
 <script type="application/javascript">
 "use strict";
 
+const isWebRender =
+  SpecialPowers.DOMWindowUtils.layerManagerType == 'WebRender';
+
 /** Test for css3-animations running on the compositor thread (Bug 964646) **/
  
 // Global state
 var gDisplay = document.getElementById("display")
   , gDiv     = null;
 
 // Shortcut omta_is and friends by filling in the initial 'elem' argument
 // with gDiv.
@@ -332,19 +335,23 @@ async function testFillMode(fillMode, fi
             desc + "affects value after animation");
   else
     omta_is("transform", { tx: 30 }, RunningOn.MainThread,
             desc + "does not affect value after animation");
 
   done_div();
 }
 
-addAsyncAnimTest(function() { return testFillMode("", false, false); });
-addAsyncAnimTest(function() { return testFillMode("none", false, false); });
-addAsyncAnimTest(function() { return testFillMode("forwards", false, true); });
+// FIXME: Bug 1456679: On WebRender these test cases incorrectly get style value
+// on the compositor when the animation is in-delay phase.
+if (!isWebRender) {
+  addAsyncAnimTest(function() { return testFillMode("", false, false); });
+  addAsyncAnimTest(function() { return testFillMode("none", false, false); });
+  addAsyncAnimTest(function() { return testFillMode("forwards", false, true); });
+}
 addAsyncAnimTest(function() { return testFillMode("backwards", true, false); });
 addAsyncAnimTest(function() { return testFillMode("both", true, true); });
 
 // Test that animations continue running when the animation name
 // list is changed.
 //
 // test_animations.html combines all these tests into one block but this is
 // difficult for OMTA because currently there are only two properties to which