Back out b00b37cb64ef (bug 1298709) for static analysis bustage
authorPhil Ringnalda <philringnalda@gmail.com>
Mon, 05 Sep 2016 20:14:56 -0700
changeset 356301 0f431005c078af72bb30cfea04a362aca97b8868
parent 356300 00bdb9edbe56af8e06c515e8c03f0026a5500933
child 356302 94bf7c3ec5aa4a51eb69774cead8ef0313c6fa35
push id1324
push usermtabara@mozilla.com
push dateMon, 16 Jan 2017 13:07:44 +0000
treeherdermozilla-release@a01c49833940 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1298709
milestone51.0a1
backs outb00b37cb64ef7088a7fd83f59d9974dee2b29caf
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Back out b00b37cb64ef (bug 1298709) for static analysis bustage CLOSED TREE
view/nsView.cpp
--- a/view/nsView.cpp
+++ b/view/nsView.cpp
@@ -778,18 +778,18 @@ void nsView::List(FILE* out, int32_t aIn
   for (i = aIndent; --i >= 0; ) fputs("  ", out);
   fprintf(out, "%p ", (void*)this);
   if (nullptr != mWindow) {
     nscoord p2a = mViewManager->AppUnitsPerDevPixel();
     LayoutDeviceIntRect rect = mWindow->GetClientBounds();
     nsRect windowBounds = LayoutDeviceIntRect::ToAppUnits(rect, p2a);
     rect = mWindow->GetBounds();
     nsRect nonclientBounds = LayoutDeviceIntRect::ToAppUnits(rect, p2a);
-    nsrefcnt widgetRefCnt = mWindow->AddRef() - 1;
-    mWindow->Release();
+    nsrefcnt widgetRefCnt = mWindow.get()->AddRef() - 1;
+    mWindow.get()->Release();
     int32_t Z = mWindow->GetZIndex();
     fprintf(out, "(widget=%p[%" PRIuPTR "] z=%d pos={%d,%d,%d,%d}) ",
             (void*)mWindow, widgetRefCnt, Z,
             nonclientBounds.x, nonclientBounds.y,
             windowBounds.width, windowBounds.height);
   }
   nsRect brect = GetBounds();
   fprintf(out, "{%d,%d,%d,%d}",